fix(dotnet): serve should work with dotnet 8#873
Merged
AgentEnder merged 1 commit intomasterfrom Jul 28, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f801df4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
In .NET 8 some changes made passing `--configuration Debug` invalid. This PR swaps that to look more like `--property:Configuration=Debug` wihch should work in both .NET 8 and lower
AgentEnder
force-pushed
the
fix/serve-command-invalid-dotnet-8
branch
from
2f68069 to
f801df4
Compare
|
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In .NET 8 some changes made passing
--configuration Debuginvalid. This PR swaps that to look more like--property:Configuration=Debugwihch should work in both .NET 8 and lowerFixes #865