Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

fix(core): avoid terminal popups on windows#887

Merged
AgentEnder merged 2 commits into
nx-dotnet:masterfrom
Den-dp:fix/avoid-terminal-popups-on-windows
Sep 7, 2024
Merged

fix(core): avoid terminal popups on windows#887
AgentEnder merged 2 commits into
nx-dotnet:masterfrom
Den-dp:fix/avoid-terminal-popups-on-windows

Conversation

@Den-dp
Copy link
Copy Markdown
Contributor

@Den-dp Den-dp commented Aug 18, 2024

Helps to avoid Terminal popups on Windows by enforcing { windowsHide: true }.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Aug 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c09eb82. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@Den-dp
Copy link
Copy Markdown
Contributor Author

Den-dp commented Aug 20, 2024

Hey @AgentEnder, any suggestions on how to fix failing CI?

I also tried running this failing nx run core-e2e:e2e task on the master branch and got the same errors as here, so it looks like not my changes introduced this regression

master:
image
pr:
image

@getlarge
Copy link
Copy Markdown
Contributor

getlarge commented Sep 2, 2024

@Den-dp Your PR should be able to pass the tests now!

Helps to avoid Terminal popups on Windows by enforcing `{ windowsHide: true }`.
@Den-dp Den-dp force-pushed the fix/avoid-terminal-popups-on-windows branch from 6049a43 to c09eb82 Compare September 7, 2024 13:29
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 7, 2024

@Den-dp
Copy link
Copy Markdown
Contributor Author

Den-dp commented Sep 7, 2024

@getlarge wow, sounds great! Thanks a lot

I'll rebase it and check it out

@Den-dp
Copy link
Copy Markdown
Contributor Author

Den-dp commented Sep 7, 2024

hey @AgentEnder, would you mind approving CI re-run

@AgentEnder AgentEnder merged commit c7127a0 into nx-dotnet:master Sep 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 7, 2024

🎉 This PR has been released in 2.4.5 🎉

The release is available on:

Please test and let us know if there are any issues 🎉

@Den-dp Den-dp deleted the fix/avoid-terminal-popups-on-windows branch September 7, 2024 20:36
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants