feat(core): update to Nx 20#918
Conversation
| @@ -0,0 +1,23 @@ | |||
| # path to a directory with all packages | |||
There was a problem hiding this comment.
I'm not sure why this was removed during the migration to Nx 19 but this is required by the sandbox creation script. It seems to be working fine.
There was a problem hiding this comment.
I noticed the same thing and did the same recovery as you
| for (const ref of change.githubReferences ?? []) { | ||
| if (ref.type === 'issue' || ref.type === 'pull-request') { | ||
| await handleIssueOrPr(client, ref.value, opts.releaseVersion); | ||
| export default class extends DefaultChangelogRenderer { |
There was a problem hiding this comment.
Not sure how to test this but I think it should work with the new version of the changelog renderer
|
🙏thank you for putting in the effort @Tommy228 . |
|
This would be great to have. Thank you! |
|
View your CI Pipeline Execution ↗ for commit 6ac3abf.
☁️ Nx Cloud last updated this comment at |
AgentEnder
left a comment
AgentEnder
left a comment
There was a problem hiding this comment.
This looks good 🎉 - one comment. I appreciate jumping in and getting this ball rolling, its something I've been meaning to get around to but parental leave + holidays pushed back quite a bit.
Let's get it green and merged 😄
| }, | ||
| "homepage": "https://nx-dotnet.com/", | ||
| "version": "*" | ||
| "version": "0.0.0" |
There was a problem hiding this comment.
This change seems unrelated / a bit weird. What's the reason for it?
There was a problem hiding this comment.
Would this cause an issue? I did this to fix the sandbox creation script where I replaced the old publish-all script with the Nx release programmatic API.
When computing the next version Nx release was not accepting * as the current version so it failed with this error.
NX Running release version for project: utils
utils 🔍 Reading data for package "@nx-dotnet/utils" from dist/packages/utils/package.json
utils 📄 Resolved the current version as * from dist/packages/utils/package.json
utils 📄 Using the provided version specifier "99.99.99".
NX Invalid semver version "*" provided.
This is ok on the CI/CD as it gets the current version for the latest git tag and ignores the *, but it fails when forking as there is no git tag.
I had to move the git options from nx.json for the same reason otherwise it fails with this error
NX The "release.git" property in nx.json may not be used with the "nx release version" subcommand or programmatic API. Instead, configure git options for subcommands directly with "release.version.git" and "release.changelog.git".
There was a problem hiding this comment.
Would this cause an issue? I did this to fix the sandbox creation script where I replaced the old
publish-allscript with the Nx release programmatic API.When computing the next version Nx release was not accepting
*as the current version so it failed with this error.NX Running release version for project: utils utils 🔍 Reading data for package "@nx-dotnet/utils" from dist/packages/utils/package.json utils 📄 Resolved the current version as * from dist/packages/utils/package.json utils 📄 Using the provided version specifier "99.99.99". NX Invalid semver version "*" provided.This is ok on the CI/CD as it gets the current version for the latest git tag and ignores the
*, but it fails when forking as there is no git tag.I had to move the git options from
nx.jsonfor the same reason otherwise it fails with this errorNX The "release.git" property in nx.json may not be used with the "nx release version" subcommand or programmatic API. Instead, configure git options for subcommands directly with "release.version.git" and "release.changelog.git".
I recall a similar issue I made a while ago dealing with version '*' as well:
#876 (comment)
Idk if that is related to this?🤷
There was a problem hiding this comment.
@EelcoLos Not related 😄 .
@Tommy228 that sounds fine. Can you take a look at the failing CI tasks?
|
Failing tests look related to the swagger codegen. I’ll look into it. |
|
|
Failing tasks were indeed related to the swagger codegen. The failing test was unrelated to swagger but was missing I have updated |
|
@allcontributors-bot add @Tommy228 for code |
|
@all-contributors add @Tommy228 for code |
|
I've put up a pull request to add @Tommy228! 🎉 |
|
🎉awesome! |
|
@Tommy228 - Thanks again! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
This is my attempt to fix the sandbox creation script and update to Nx 20.
In my understanding, Nx 20 has dropped support for NxPluginV1. However, V2 is already supported so I have simply removed all "legacy" code related to V1. This should be fine as V2 is supported since Nx 16.7.0 according to the docs and peer deps are already requiring Nx 18+ today. I'm not sure if this is the right approach and would appreciate some feedback.
Fixes #911