Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented: Message handler system and workflow event option drop down menu #13
Conversation
brookinsconsulting
added some commits
Oct 12, 2014
brookinsconsulting
force-pushed the
brookinsconsulting:message-handler-system
branch
from
68903da
to
a7767c7
Oct 12, 2014
added a commit
that referenced
this pull request
Oct 16, 2014
SerheyDolgushev
merged commit 451f77c
into
nxc:master
Oct 16, 2014
brookinsconsulting
deleted the
brookinsconsulting:message-handler-system
branch
Oct 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brookinsconsulting commentedOct 12, 2014
Implemented: Url link shorten handler workflow event option drop down menu
Implemented: Message handler system and workflow event option drop down menu
Hello NXC,
In the past if you only wanted to customize the message or format of message posted to a social network you had to override a custom 'PublishHandler' for each social network.
Changes
Our pull request today provides for specific customization of only the message for each social network.
Our pull request provides for a new workflow event option 'Message Handler' drop down select menu populated with each 'MessageHandlers' ini setting class.
This makes it simple for admins to use this feature to customize the message handler to be used for each social network instead of just one global ini settings based default message handler for all social networks.
The order of message handlers displayed in the workflow event options drop down is configurable via ini settings order, first listed, first displayed.
We think this improvement is worth of a pull request because it increases the flexibility to customize only the message text / format / etc. used for each social network or for all (except linkedin) via workflow event options instead of by customizing the 'PublishHandler' for each social network which is most often unnecessary.
Our pull request today is based upon our last pull request #12 changes since we reuse many small parts. Be certain to merge #12 first before merging this pull request.
LinkedIn Warning
Warning: Due to the uniqueness of the LinkedIn share API we found that it was best to separate the message handler functionality into it's own handler to allow for maximum flexibility. In future use or upgrades of this extension to include this functionality for LinkedIn sharing to work ... the admin must change the related workflow event options and must select the 'LinkedIn' message handler in the drop down select menu.
The rest of the default social networks (Twitter, Facebook) work by default with no workflow event option changes required but even while not required it is best to make a selection using the 'Message Handler' drop down select menu.
Closing
Please let us know what you think! We are very excited with our recent progress on this project.
Cheers,
Brookins Consulting