Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two crashes/segfaults in
profile_load
which could be turned into arbitrary writes. First, thefgetl
andfgeti
functions don't check if you've reached the end of the file, which causes a too-smallprofile.dat
to fill theProfile
with whatever garbage stack values and leads to a crash, if you callprofile_load
directly.In the next crash we set the item type to some large value, like
0x5C000000
.When we reach the following code block, we'll attempt to write to some large offset and most likely segfault.
This patch fixes the two crashes by adding a check to the
fgeti
andfgetl
functions and making sure thetype
is within the maximum number of weapons.Note: I have no idea if this will break existing saves in some way, but I don't think it will. I have a similar PR open in the NXEngine repo: EXL/NXEngine#9.