From 6f0c7228d7e8dab880fce631a80df47d8a90061d Mon Sep 17 00:00:00 2001 From: Norbert Kwizera Date: Mon, 19 Feb 2018 20:37:17 +0200 Subject: [PATCH] Add support GET request too for CK --- handlers/chikka/chikka.go | 5 +++++ handlers/chikka/chikka_test.go | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/handlers/chikka/chikka.go b/handlers/chikka/chikka.go index b6ea3611c..d7a7a2977 100644 --- a/handlers/chikka/chikka.go +++ b/handlers/chikka/chikka.go @@ -26,6 +26,11 @@ func init() { // Initialize is called by the engine once everything is loaded func (h *handler) Initialize(s courier.Server) error { h.SetServer(s) + err := s.AddHandlerRoute(h, http.MethodGet, "receive", h.ReceiveMessage) + if err != nil { + return err + } + return s.AddHandlerRoute(h, http.MethodPost, "receive", h.ReceiveMessage) } diff --git a/handlers/chikka/chikka_test.go b/handlers/chikka/chikka_test.go index 4595a94f0..4a6d15fb2 100644 --- a/handlers/chikka/chikka_test.go +++ b/handlers/chikka/chikka_test.go @@ -24,9 +24,13 @@ var testCases = []ChannelHandleTestCase{ {Label: "Receive Valid", URL: receiveURL, Data: validReceive, Status: 200, Response: "Message Accepted", Text: Sp("Hello World"), URN: Sp("tel:+639178020779"), ExternalID: Sp("4004"), Date: Tp(time.Date(2016, 03, 11, 04, 20, 59, 690000128, time.UTC))}, + {Label: "Receive Valid via GET", URL: receiveURL + "?" + validReceive, Status: 200, Response: "Message Accepted", + Text: Sp("Hello World"), URN: Sp("tel:+639178020779"), ExternalID: Sp("4004"), + Date: Tp(time.Date(2016, 03, 11, 04, 20, 59, 690000128, time.UTC))}, {Label: "Ignore Invalid message_type", URL: receiveURL, Data: "message_type=invalid", Status: 200, Response: "unknown message_type request"}, {Label: "Status Sent Valid", URL: receiveURL, Data: validSentStatus, Status: 200, Response: `"status":"S"`}, + {Label: "Status Sent Valid via GET", URL: receiveURL + "?" + validSentStatus, Status: 200, Response: `"status":"S"`}, {Label: "Status Failed Valid", URL: receiveURL, Data: validFailedStatus, Status: 200, Response: `"status":"F"`}, {Label: "Status Invalid", URL: receiveURL, Data: invalidStatus, Status: 400, Response: `must be either 'SENT' or 'FAILED'`}, }