Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include router fields in PO extraction for subflow, webhook nodes etc #1076

Closed
rowanseymour opened this issue Dec 29, 2021 · 3 comments

Comments

@rowanseymour
Copy link
Member

Not quite sure yet what the logic here should be - it kinda needs to match what the editor considers localizable but the engine doesn't know about node types in the UI. Maybe for any node that has both an action and a router, the router isn't localizable?

@rowanseymour
Copy link
Member Author

rowanseymour commented Jan 5, 2022

@ericnewcomer maybe it's ok if PO translation doesn't cover everything translatable in the UI. We could say that it includes everything the engine considers localizable on actions only.. and I think that would be a subset of everything the editor considers translatable. That way people can use it for send message text... but router args, which usually require more context, should be translated in the editor.

@ericnewcomer
Copy link
Member

I think it's an anti-pattern to translate rules outside the context of a flow, so I'm all for removing them here. Slightly less convinced about categories though.

@rowanseymour
Copy link
Member Author

We got rid of option to include router arguments (change is actually in mailroom to exclude properties called arguments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants