Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

AutoFiling - wouldn't it be more sensible to use OriginalPublishedDate? #6

Open
cloph opened this Issue Jul 6, 2011 · 1 comment

Comments

Projects
None yet
2 participants

cloph commented Jul 6, 2011

Currently, when using AutoFiling, the news items get filed according to their creation time, i.e the time the page is saved in the CMS.

To me it would be more straightforward if it used the "first published" date instead.

Is there a reason for using creation date? If so, might be worth to add to the readme :-)

changing it for me is simple (getPartitionedHolderForArticle - just replace $article->Created with $article->OriginalPublishedDate ) - I wonder more about the decision/rationale behind this.

Owner

nyeholt commented Jul 7, 2011

Good idea. The existing rationale is that OriginalPublishedDate wasn't always set (and wasn't defaulted to 'now'), meaning it would have been blank. But it probably would be better to use that date if set, or fall back to Created. If you want to submit a pull request with that change I'll merge it, or when I get a chance will add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment