Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom headers field for drafts and messages #223

Conversation

mrashed-dev
Copy link
Collaborator

Description

This PR adds support to the custom headers field used to attach headers to message and draft objects.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (ded393a) to head (b50ca26).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #223   +/-   ##
=========================================
  Coverage     80.46%   80.46%           
  Complexity      281      281           
=========================================
  Files            29       29           
  Lines           824      824           
  Branches         79       79           
=========================================
  Hits            663      663           
  Misses          119      119           
  Partials         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mrashed-dev mrashed-dev merged commit 6d4f58d into main Apr 30, 2024
2 checks passed
@mrashed-dev mrashed-dev deleted the TW-2808-kotlin-add-support-for-custom-headers-field-for-outgoing-messages branch April 30, 2024 03:19
@mrashed-dev mrashed-dev mentioned this pull request Apr 30, 2024
mrashed-dev added a commit that referenced this pull request Apr 30, 2024
# Changelog
### Added
* Added missing webhook triggers (#220)
* Added provider field to token exchange response (#225)
* Added support for clean messages endpoint (#226, #228)
* Added support for custom headers field for Drafts and Messages (#223)
* Added support for overriding various fields of outgoing requests
(#224)

### Changed
* Fixed issue where attachments < 3mb were not being encoded correctly
(#227, #222)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants