[TSDK-483] Fix authentication for integrations #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, running b64encode without decoding it back again returns a byte string instead of a string
mrashed-dev
requested review from
a team,
dominicj-nylas,
mypile and
theblueskies
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 95.83% 95.96% +0.12%
==========================================
Files 15 15
Lines 1634 1634
==========================================
+ Hits 1566 1568 +2
+ Misses 68 66 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mrashed-dev
requested review from
a team,
dantonpimentel and
jumbhood
and removed request for
a team,
dominicj-nylas and
mypile
theblueskies
approved these changes
Sep 21, 2022
mrashed-dev
deleted the
TSDK-483-integrations-basic-auth-is-invalid-for-python
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Python 2.7 the
'b'prefix ahead of a string is ignored but in Python 3 it indicates a byte literal versus a string. So on Python 3 apps implementing our SDK they would encounter an error as the Nylas API is expecting a string instead of a byte string. Now we ensure that it gets decoded back into a string to ensure it works on Python 3.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.