Start initial work on a Python 3 port #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just gets the tests passing, no further work in validating the bindings on Python 3 was done yet.
Interesting notes - since
__getitem__raises aKeyError, not anAttributeError,hasattrwould bomb out. Neat.This also eagerly consumes the
map(since it's -- rightly -- an iterator), and does something similar with.items(which will be an iterator in Python 3 - I opted to not do two codepaths there, since the gain looks to be minimal usually)