Skip to content

Conversation

@paultag
Copy link
Contributor

@paultag paultag commented Mar 10, 2015

This just gets the tests passing, no further work in validating the bindings on Python 3 was done yet.

Interesting notes - since __getitem__ raises a KeyError, not an AttributeError, hasattr would bomb out. Neat.

This also eagerly consumes the map (since it's -- rightly -- an iterator), and does something similar with .items (which will be an iterator in Python 3 - I opted to not do two codepaths there, since the gain looks to be minimal usually)

 This just gets the tests passing, no further work in validating the
 bindings on Python 3 was done yet.
@paultag paultag force-pushed the paultag/bugfix/python3 branch from 386ff2a to 2ae9a24 Compare March 10, 2015 04:09
@spang
Copy link
Contributor

spang commented Mar 10, 2015

Cool! If you can sign our CLA, I'm happy to merge this: https://nilas.com/cla.html

We should consider adding a tox config file for Python 2.7 and 3.whatever, otherwise we're sure to break support at some point.

@paultag
Copy link
Contributor Author

paultag commented Mar 10, 2015

I'll send in another PR tonight; CLA signed

On Tue, Mar 10, 2015 at 3:16 PM, Christine Spang notifications@github.com
wrote:

Cool! If you can sign our CLA, I'm happy to merge this:
https://nilas.com/cla.html

We should consider adding a tox config file for Python 2.7 and 3.whatever,
otherwise we're sure to break support at some point.


Reply to this email directly or view it on GitHub
#4 (comment).

:wq

@paultag paultag mentioned this pull request Mar 11, 2015
spang added a commit that referenced this pull request Mar 12, 2015
Start initial work on a Python 3 port
@spang spang merged commit 755879d into nylas:master Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants