Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make siteId configurable with an environment variable #115

Merged
merged 6 commits into from Oct 7, 2019

Conversation

@walsh9
Copy link
Contributor

commented Oct 7, 2019

This isn't really an ideal solution for multisite support as environment variables will start to pile up for different sites (PROD_GOTHAMIST_SITE_ID, PROD_WNYC_SITE_ID, etc...) but for now it lets us differentiate between prod and demo...

walsh9 added 6 commits Oct 7, 2019
@walsh9 walsh9 merged commit 86ef034 into master Oct 7, 2019
3 checks passed
3 checks passed
ci/circleci: build-static Your tests passed on CircleCI!
Details
ci/circleci: deploy-static-qa Your tests passed on CircleCI!
Details
ci/circleci: test-static Your tests passed on CircleCI!
Details
@walsh9 walsh9 deleted the mwalsh/site-id-config branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.