Skip to content
Branch: dev
Commits on Jul 11, 2019
  1. Fix bug in regex for extracting location ids

    KevinCaseiras committed Jul 11, 2019
    fixes #12793
Commits on Jul 3, 2019
  1. Fix bug when updating unconsolidated law trees

    stouffers committed Jul 3, 2019
    There was a bug that occurred when updating the law tree for certain
    unconsolidated laws.  This subset of unconsolidated laws do not have
    explicitly defined root documents, so the parser creates a dummy
    document to serve as the root when the law tree is first constructed.
    The problem arises when the law tree is rebuilt for these laws.  When
    this happens, a new dummy tree node is created but not a new dummy
    document.  This causes a foreign key violation when inserting the new
    dummy tree node as it does not reference a valid document.
    I have fixed this problem by adding logic to reuse previous dummy roots
    when rebuilding the law tree:
    - Updated law document model in code and db to include a dummy flag to
      identify dummy docs.
    - When rebuilding law trees that do not have an explicit root, the
      parser will now reuse the previous root document if it has the dummy
      flag instead of creating a new dummy root.
Commits on Jun 19, 2019
Commits on Jun 7, 2019
  1. Fix notification api call failures

    aa29cala committed Jun 7, 2019
    2 api calls were mapping to the same path which was causing a 500 error
    when trying to access either url. The NotificationSubscriptionCtrl api
    call was changed to /api/3/admin/notifications/unsubscribe/{id} from
Commits on Jun 4, 2019
Commits on Jun 3, 2019
  1. Checks if an agenda location exists before accessing array

    KevinCaseiras committed Jun 3, 2019
    A recent agena alert rules file:
    is missing the location of the rules agenda requiring a change in our
  2. Add tomcat permissions to setup instructions

    stouffers committed Jun 3, 2019
    Add instructions on setting permissions for the tomcat directory to the
    setup instructions.
Commits on May 29, 2019
  1. Add session year parameter validation.

    stouffers committed May 29, 2019
    Adds a validation method that can be used to validate session year
    parameters.  Use this method in several places where session years are
    parsed in the API.
    Refs #12698
Commits on May 24, 2019
  1. Revert "Ensure text is not null when checking if it exists"

    KevinCaseiras committed May 24, 2019
    This reverts commit 0c1dfa2.
    Need to temporarially revert this because some elasticsearch code relies
    on this (i think incorrect) functionality. I will look into a larger
    solution which includes ES.
  2. Fix issues checking resolution bill text in scrape bill spotcheck

    KevinCaseiras committed May 24, 2019
    The scraped bill spotcheck report was not correctly checking/handling
    cases of openleg having null text if the reference did have text.
    First fix, if the openleg bill amendment text is null, set it to an
    empty string to avoid NPE's when regex matching.
    Additionally this removes the ensureTextFormatExists method which was
    attempting to ensure we only compared html/plain text if necessary. However,
    there were a few issues with it:
    - When it correctly detected a missing text type, its thrown exception
    was not handled at all. So this exception would repeat every report
    until someone manually stopped it.
    - We cant avoid checking text because its not present in openleg.
    Sometimes openleg will be missing bill text and that is an important
    mismatch that we want to report.
Commits on May 23, 2019
Commits on May 6, 2019
  1. Modify pubhearing parser for new datetime format.

    stouffers committed May 6, 2019
    Recently, we have started receiving hearings with a slightly different
    date/time format that breaks the current parser.  The dates in the new
    format contain labels ("Date:" and "Time:") for the dates/times.
    This commit adjusts the parser to be able to deal with these labels.
    Also, a new test is added to test the parsing of the new date/time
    Fixes #12704
Commits on May 2, 2019
  1. Fix bug allowing creation of negative session year

    stouffers committed May 2, 2019
    There was a bug in the SessionYear class that allowed for the
    instantiation of a negative session year, even though the creation of a
    negative session is explicitly forbidden.  When a year of 0 is provided,
    it passes the non-negative validation and is then computed to a session
    year of -1.  This has caused issues where a session year of -1 is saved,
    and then causes an exception when it is loaded.
    This is addressed in this commit by validating the computed session year
    instead of the directly passed in session year.  Now, when 0 is passed
    in, it will validate the computed value of -1 and throw an exception,
    preventing negative sessions from being persisted with the processors.
    Refs #12698
Commits on Mar 12, 2019
  1. Bump version to 3.3

    kzalewski committed Mar 12, 2019
Commits on Mar 11, 2019
  1. Refactor notification subscription model

    stouffers committed Mar 11, 2019
    Some major changes to the notification subscription data model to allow
    for improved and seamless notification digest functionality.
    - Former digest behavior is now encapsulated in instant notifications
      that are sent as soon as the event occurs, with the ability to set a
      rate limit, which digests any events that occur during cool down.
    - Add scheduled notifications that can be received daily, or on specific
      days of the week at a given time.
    - Use a polymorphic data model so that different types of subscriptions
      can be properly managed without type specific code.
    - Move digest sender code into NotificationSender classes.
    - Add tests for new subscription classes, dao, and service.
    Refs #8983
Commits on Mar 6, 2019
Commits on Mar 4, 2019
  1. Change MemberCache into FullMemberCache

    aa29cala committed Mar 4, 2019
    This changes the Membercache created for ticket #12323 and turns it into
    a FullMember object cache. This allows the CachedMemberService to be
    using all of its caches more effectively and should provide a nice
    performance benefit
Commits on Feb 27, 2019
  1. Upgrade to most recent postgres jdbc version.

    stouffers committed Feb 27, 2019
    The version we were on had not been updated since 2016 and I had
    encountered a bug that was fixed in one of the subsequent versions.
Commits on Feb 26, 2019
  1. Fix Agenda alert interval spotcheck duplication key exceptions

    KevinCaseiras committed Feb 26, 2019
    My previous fix to Agenda alerts did not make the necessary changes to
    the SqlFsAgendaAlertDao. This commit:
    - Adds a year column to the agenda_alert_info_committee table
    - Refactors the SqlFsAgendaAlertDao to use the new id,
    - Removes the old id, AgendaAlertInfoCommId
    - Removes duplicate entries in the agenda_alert_info_committee table
    Also fixes a bug with processing alert files where files would be moved
    to the archive directory when an error occurred during processing.
    refs #12520
Commits on Feb 22, 2019
  1. Remove sobi references in the database

    aa29cala committed Feb 22, 2019
    fixes #11312
    With these new flyway migrations and the changes to some daos / query
    files openleg should now be essentially free of the term sobi except
    when the file directly interacts with sobi files only
Commits on Feb 21, 2019
  1. Fix array index issue in agenda report service

    stouffers committed Feb 21, 2019
    A recent modification to the BaseAgendaCheckReportService added logic
    that filtered out certain references from the incoming reference list.
    If all references were filtered out, this created an index exception
    later on when the code attempts to access the first reference of the
    list.  This was not a problem before because a ReferenceDataNotFoundEx
    (which is checked in the spotcheck service) was thrown if no references
    were found.
    This commit fixes this issue by throwing a ReferenceDataNotFoundEx if
    the filtered reference list is empty.
Commits on Feb 20, 2019
  1. Rename more sobi References

    aa29cala committed Feb 20, 2019
    Some more references that were missed in the first batch have been
    changed. This commit does not modify the database or the app properties
Commits on Feb 19, 2019
  1. Attempt to remove all Sobi Frag references

    aa29cala committed Feb 19, 2019
    In this huge list of changes, I have attempted to remove all instances
    of sobi fragments and tried to leave sobis in the name only if the class
    directtly dealt with sobis only. LegDataFragments will now be used
    instead of sobi fragments.
    The work isnt complete. The database and some sql queries still use sobi
    fragments. All of that must be refactored.  refs #11312
    NOTE: This commit changes some things to app properties, be sure to
    update your app properties.
Commits on Feb 15, 2019
  1. Add new session member caches

    aa29cala committed Feb 15, 2019
    New caches have been created to help aid the performance of the sensite
    bills report or anything that would access the CachedMemberService
    The cache was that was previously part of the CachedMemberService is now
    the SessionMemberIdCache
    The MemberIdCache returns member (not session members) based off their
    The SessionChamberShortNameCache returns a session member given the
    session chamber and shortname of a senate member
  2. Simplify committee data model in db.

    stouffers committed Feb 15, 2019
    Simplifies the committee data model in the database by removing several
    redundant fields
    The main area of simplification is the "reformed" column of the
    committee_version table, which was a redundant value that matched the
    "created" value of the next version's row.  The redundancy technically
    made it more efficient to query for point in time data, but it added
    complexity in the dao layer.
    This commit refactors the dao to use just the "created" time for queries
    and computing the "reformed" time using a subquery.  It also simplifies
    some of the update logic and removes a number of unused queries and DAO
    Fixes #12203
Commits on Feb 13, 2019
  1. Update Json Api Docs

    aa29cala committed Feb 13, 2019
    Our json api docs had some api calls that did not work and some that
    could use some clarification between the processed and published dates.
    Some api calls repsonses were updated as well.
    refs #12306
  2. Add null check during spotcheck html cleaning

    stouffers committed Feb 13, 2019
    Add a null check in the cleanHtml method in the bill scrape check
    service to prevent it from attempting to parse html from a null string.
  3. Fix spotcheck ordering for int keys.

    stouffers committed Feb 13, 2019
    Fix a bug where integer key values are sorted as if they were strings
    in the spotcheck query.  This is because the int values are stored in an
    hstore and are retrieved as strings.  This is fixed by converting the
    retrieved value to an int when sorting.
You can’t perform that action at this time.