Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptionEx] Issue when other plugin add new option command #1

Closed
RyanBram opened this issue Feb 20, 2022 · 7 comments
Closed

[OptionEx] Issue when other plugin add new option command #1

RyanBram opened this issue Feb 20, 2022 · 7 comments

Comments

@RyanBram
Copy link

RyanBram commented Feb 20, 2022

Hi, Developer.
Thank you for your wonderful collection of plugins, which make it possible to create visual novels with RPG Maker MZ.

I'm currently trying to use OptionEx where this plugin makes the Option Window even nicer. I'm currently having an issue, when your plugin is combined with Sasuke KANNAZUKI's BattleSystemSelectable.js.

Here is how it looks:

  1. If the OptionEx plugin is placed before BattleSystemSelectable.js the new option will be placed after "Reset to Default" which visually is not very good.
    Before

  2. If the OptionEx plugin is placed after BattleSystemSelectable.js we need to scroll the window to select "Reset to Default"
    After

Then I have a suggestion that OptionEx also provide an "Option Window Height" plugin parameter in addition to the already existing "Option Window Width". And also an option to choose other Windowskin for Option Window will be nice to have.

Thank you very much for your support.

@nz-prism
Copy link
Owner

nz-prism commented Feb 21, 2022

Hi RyanBram,

Thank you so much for your feedback!

I could reproduce your issue and corrected it by updating the plugin ver. 1.2.3.
Please check it out!

Basically, the window height stretches based on the number of option items. However, the number of max items was previously limited only "16", which was the main cause of the issue. Now it calculates the max number based on the screen height and the item height. I think it automatically solves the issue but if not, try lowering the plugin parameters "Option Item Height", "Font Size" and "Default Command Offset".

By updating the plugin and place it under BattleSystemSelectable.js, the screen will be like;

スクリーンショット 2022-02-21 17 27 45

As for the Windowskin, the option does not appear if the plugin parameter "Windowskins" has only 1 window image file. By adding more image files, the option should appear.

If you have any questions, feel free to ask me!

Thanks,
nz_prism

@RyanBram
Copy link
Author

RyanBram commented Feb 22, 2022

Hi, nz-prism.

Thanks a lot for the quick fix.

I've downloaded the latest version of OptionEx and confirmed that this plugin is compatible with BattleSystemSelectable.js. However I still find a little issue if I set the window width to 812px, while I also set the "UI Area Width" in "System 2" at 812px, where touch control is blocking the option window as shown below:
Option

My suggestion is to lower the options window a little bit down as the main menu for the placement of touch controls.
Menu

Although it seems that with position adjustment, the number of options displayed will exceed the screen so scrolling is still necessary. But I see this is neater than the previous version.

As for the Windowskin, the option does not appear if the plugin parameter "Windowskins" has only 1 window image file. By adding more image files, the option should appear.

I am sorry for the lack of clear explanation. What I mean by windowskin is the plugin parameter that allows the windowskin used by OptionEx to be different from the windowskin in other menu scenes. This makes OptionEx look unique and less generic.

ご支援ありがとうございました
Ryan Bram

@nz-prism
Copy link
Owner

Hi Ryan Bram,

Thank you for the feedback again!

I've updated the plugin 1.3.0 to add a plugin parameter "Place Option Window Under Buttons";
スクリーンショット 2022-02-24 17 47 26

If it's set true, the window is placed under the buttons;
スクリーンショット 2022-02-24 17 45 37

If false;
スクリーンショット 2022-02-24 17 46 23

I believe this update will solve the issue. Check it out!

Note if the window is placed under the buttons, the window height decreases instead. If it doesn't accommodate all the items, lower "Option Item Height".

I am sorry for the lack of clear explanation. What I mean by windowskin is the plugin parameter that allows the windowskin used by OptionEx to be different from the windowskin in other menu scenes. This makes OptionEx look unique and less generic.

Sorry for misunderstanding. That's an interesting suggestion but I'd say it's difficult to implement since it must conflict against the existing option item "Windowskin".
But thank you, your suggestions are always welcomed!

If you have any questions, please let me know.

こちらこそありがとうございます!
nz_prism

@RyanBram
Copy link
Author

RyanBram commented Mar 4, 2022

Hi, nz-prism.
Sorry that I'm very slow in replying to your messages.

I've tried the last update of option-ex.js and I can say that the "Place Option Window Under Buttons" option works very well. However there is a slight issue that I encountered, where "Option Window Width" has a different output than "UI Area Width".

In the "UI Area Width" I set the value to 812, but if I enter the same value in the "Option Window Width" then the result is the option window is wider than it should be, so I have to lower the value in the "Option Window Width" to 804 to be the same like 812 in "UI Area Width".

Then I found the window height is also different from what I set in "UI Area Height" which is 624.

ご清聴ありがとうございました。

Ryan

@nz-prism
Copy link
Owner

nz-prism commented Mar 5, 2022

Hi Ryan,

Thank you for the feedback!

Actually, it's a matter of a "preference". Currently I don't set any upper limit to "Option Window Width", which brings your issue.

The width of RMMZ standard windows which stretch from the left-end to the right-end, such as a status window, has a padding;

スクリーンショット 2022-03-05 8 57 11

See, the windows is a little smaller than the screen width. The formula is;

Graphics.boxWidth = uiAreaWidth - 8
Graphics.boxHeight = uiAreaHeight - 8

In your case, 812 - 8 = 804 is the "boxWidth".

I can use the boxWidth as an upper limit of the option window width following the RMMZ UI standards, which will be like;

スクリーンショット 2022-03-05 9 09 13

However, you can get this image even with the current version by manually specifying the same value as "boxWidth" to Option Window Width. If I limit the window width, it prevents users to set the window without a padding;

スクリーンショット 2022-03-05 9 10 02

I don't think there are many users who want it but there MIGHT be one!
I'm afraid to say but I ask you to manually set 804 to Option Window Width since I don't want to limit any preferences of users.

ありがとうございます,
nz_prism

@RyanBram
Copy link
Author

RyanBram commented Mar 5, 2022

Hi, nz-prism, (^_^)

I understand about your design regarding this plugin.
Since it is by design, for me it is no longer an issue, after all, my problem is very easy to solve.

Thus I will close this Github Issue. But before I really close this issue, I'd like to ask your permission to open a few more issues to give me some ideas regarding your other plugins. Because thanks to your plugins, I'm so happy to be able to create visual novels with RPG Maker MZ without the need for any other software. Where previously I relied on plugins from Lunatlazur in RPG Maker MV.

Would you mind if I open another issue?

Thank you very much.
Ryan.

@nz-prism
Copy link
Owner

nz-prism commented Mar 6, 2022

Hi Ryan,

Thank you!

Thus I will close this Github Issue. But before I really close this issue, I'd like to ask your permission to open a few more issues to give me some ideas regarding your other plugins. Because thanks to your plugins, I'm so happy to be able to create visual novels with RPG Maker MZ without the need for any other software. Where previously I relied on plugins from Lunatlazur in RPG Maker MV.

Would you mind if I open another issue?

Not at all! I always welcome your feedbacks.
My plugin is so "young" that it might have a lot of potential issues. Your feedbacks bring it up!

Thank you for using my plugin and filing this issue. If you have any questions, feel free to ask me!

どういたしまして,
nz_prism

@RyanBram RyanBram closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants