Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

New buildr task for npm version of jslint. Works on Windows, OSX and unix. #1

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Added a new buildr task for the npm version of jslint.

Owner

nzakas commented May 21, 2012

I'm not a fan of this approach. Since Node.js and npm are available on all platforms, shouldn't the npm version of JSLint work the same on all of them?

I agree that they should work the same on all platforms. I can't tell if this is a node/npm issue or an ant issue. Personally I am leaning towards it being an ant issue because others have reported similar issues with ant's exec task on windows. The issue seems to only occur when calling a batch file that in turn calls other commands that create output to stdout. It seems ant is capturing the stdout of the batch file, but can't see the stdout from it's child processes because of the way it invokes the batch file. (Googling around you'll see others have had a similar issue with perl scripts used in batch files that are called by ant on windows. As well, there is this stackoverflow link that I commented on... http://stackoverflow.com/questions/1602616/how-can-i-ensure-all-output-from-ants-exec-task-goes-to-stdout)

Regardless... it's an issue that needs to be worked around. I would rather not work around it with the approach I came up with... but it seems to be the only solution today.

Unfortunately I don't have the interest/time to look into this problem further... So I am not that concerned if you accept the pull request or not. If others find the workaround/approach interesting, they can use it. And you and others have the info if you want to research this problem further with related tasks for buildr on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment