Mavenizing this project #43

Closed
wants to merge 7 commits into
from

Projects

None yet

2 participants

@emecell
emecell commented Mar 10, 2013

Hey Nicholas,

I attempted to mavenize your project for pushing to Sonatype's central repo (fix for #15). I know you said you had no plans to convert to maven but it's been 3 years and the maven repo is definitely the go to place for java open source projects. There were a couple of things I wasn't sure about while converting your project given the structure of it:

  • Licence section in the pom.xml: I believe you're using the MIT license but I did not link to it directly
  • groupId: I just used what the top level java package was
  • jArgs is not in the central repo and it's discouraged to use things not uploaded to the central repo. I'm unclear if Sonatype has a hard fast rule about this. You may want to consider converting to use commons-cli or something similar.
  • your build.xml produces two artifacts and it's typical with maven to only produce one per project (http://www.sonatype.com/people/2010/01/how-to-create-two-jars-from-one-project-and-why-you-shouldnt/)

Also, I'm no authority on managing a project in a maven repo but the instructions on their site are pretty straightforward.

Cheers!

@nzakas
Owner
nzakas commented Mar 10, 2013

Thanks for doing this. Unfortunately, I don't want to merge it in because I
don't have the time to manage it on Maven Central. My longer-term plan is
to convert this to a Node.js utility.

On Sun, Mar 10, 2013 at 2:58 PM, Robert Law notifications@github.comwrote:

Hey Nicholas,

I attempted to mavenize your project for pushing to Sonatype's central
repo http://www.sonatype.org/central/participate (fix for #15#15).
I know you said you had no plans to convert to maven but it's been 3 years
and the maven repo is definitely the go to place for java open source
projects. There were a couple of things I wasn't sure about while
converting your project given the structure of it:

  • Licence section in the pom.xml: I believe you're using the MIT
    license but I did not link to it directly
  • groupId: I just used what the top level java package was
  • jArgs is not in the central repo and it's discouraged to use things
    not uploaded to the central repo. I'm unclear if Sonatype has a hard fast
    rule about this. You may want to consider converting to use commons-clihttp://commons.apache.org/proper/commons-clior something similar.
  • your build.xml produces two artifacts and it's typical with maven to
    only produce one per project (
    http://www.sonatype.com/people/2010/01/how-to-create-two-jars-from-one-project-and-why-you-shouldnt/
    )

Also, I'm no authority on managing a project in a maven repo but the instructions
on their sitehttps://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guideare pretty straightforward.

Cheers!

You can merge this Pull Request by running

git pull https://github.com/emecell/cssembed mavenize

Or view, comment on, or merge it at:

#43
Commit Summary

  • Prepping .gitignore for maven / eclipse
  • Initial conversion to maven: moving files under src/main/java and
    src/test/java and adding initial pom.xml.
  • Adjusting ant.properties to point to maven dirs
  • Setting the correct version
  • Shortening name in pom.xml
  • Prepping for initial central repo
  • Linking to main project for license. Tagging branch as fix for #15.

File Changes

  • M .gitignorehttps://github.com/nzakas/cssembed/pull/43/files#diff-0(13)
  • M ant.propertieshttps://github.com/nzakas/cssembed/pull/43/files#diff-1(4)
  • A pom.xml https://github.com/nzakas/cssembed/pull/43/files#diff-2(161)
  • A src/main/java/net/nczonline/web/cssembed/CSSEmbed.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-3(0)
  • A src/main/java/net/nczonline/web/cssembed/CSSEmbedTask.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-4(0)
  • A src/main/java/net/nczonline/web/cssembed/CSSURLEmbedder.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-5(0)
  • A src/main/java/net/nczonline/web/datauri/Base64.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-6(0)
  • A src/main/java/net/nczonline/web/datauri/DataURI.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-7(0)
  • A src/main/java/net/nczonline/web/datauri/DataURIGenerator.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-8(0)
  • A src/main/javadoc/stylesheet.csshttps://github.com/nzakas/cssembed/pull/43/files#diff-9(109)
  • A src/test/java/net/nczonline/web/cssembed/CSSURLEmbedderTest.javahttps://github.com/nzakas/cssembed/pull/43/files#diff-10(0)
  • A src/test/resources/net/nczonline/web/cssembed/folder.pnghttps://github.com/nzakas/cssembed/pull/43/files#diff-11(0)
  • A src/test/resources/net/nczonline/web/cssembed/samefiletest.csshttps://github.com/nzakas/cssembed/pull/43/files#diff-12(0)
  • D tests/net/nczonline/web/cssembed/folder.pnghttps://github.com/nzakas/cssembed/pull/43/files#diff-13(0)
  • D tests/samefiletest.csshttps://github.com/nzakas/cssembed/pull/43/files#diff-14(1)

Patch Links:


Nicholas C. Zakas
@slicknet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@emecell
emecell commented Mar 11, 2013

Ah, that's understandable and unfortunate. I'll close out this request. I'll probably just create a maven version of this project myself for the thing I was working on. Thanks for considering it!

@emecell emecell closed this Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment