Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Conversation

@guylil
Copy link

@guylil guylil commented Nov 20, 2017

Test should pass but doesn't

#goodnessSquad @mightyiam

@j-f1
Copy link
Collaborator

j-f1 commented Nov 20, 2017

Thanks for contributing this failing test!

Can you run npm run lint -- --fix and push the changes? This will fix the lint errors so that Travis can run your tests.

@mightyiam
Copy link
Contributor

@j-f1 the prettier failures are unrelated. I suggest they be handled in the form of #93 or #94.

@JamesHenry
Copy link
Collaborator

Thanks for contributing, @guylil! #94 has now been merged

@guylil guylil closed this Dec 6, 2017
@mightyiam
Copy link
Contributor

This should be re-opened.

@guylil guylil reopened this Dec 6, 2017
@mightyiam
Copy link
Contributor

This is still failing. @guylil could you please update the branch by merging master?

@bradzacher
Copy link
Owner

Hi @guylil

I'm going to close this PR due to unresponsiveness.
I've opened #177 to track this issue so others can pick it up if they like.

Feel free to submit a new PR if you want to get back into it and fix this.

@bradzacher bradzacher closed this Nov 19, 2018
Repository owner locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants