Add another triger for idle timer events #4

Merged
merged 3 commits into from Sep 12, 2012

Conversation

Projects
None yet
2 participants

Fixed idle event from being fired when user is clicking on the page

ashwinjk added some commits Sep 11, 2012

@ashwinjk ashwinjk Add support for mousedown event
Idle event was being triggered when user is still clicking on the page
dae14b7
@ashwinjk ashwinjk Revert "Add support for mousedown event"
This reverts commit dae14b7.
cd17466
@ashwinjk ashwinjk Add support for mousedown event
Fixed idle event being triggered when user is clicking on the page
9be56ea
Owner

nzakas commented Sep 11, 2012

Can you explain why this is necessary?

I had used this module to hide navigation (prev/next) buttons on a carousel module when idle. We observed that when user was clicking next/prev buttons without moving the mouse, idle event was being fired and buttons would hide.

Actually the better way to do this is probably allowing users to pass additional events to the idletimer module for triggering idle event

@nzakas nzakas added a commit that referenced this pull request Sep 12, 2012

@nzakas nzakas Merge pull request #4 from ashwinjk/master
Add another triger for idle timer events
041fc33

@nzakas nzakas merged commit 041fc33 into nzakas:master Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment