Skip to content

Nicholas C. Zakas
nzakas

Organizations

@eslint @todogroup
nzakas commented on issue eslint/eslint#5234
@nzakas

@IanVS I don't think embedding another array makes sense as an end user. We have other rules that have multiple items, I'm not sure why this one wo…

nzakas commented on issue eslint/eslint#5231
@nzakas

@WhyEvenTry these are just examples. What he's saying is that we do not have a way to know if a JSDoc block is meant as an inline type or not. Peop…

nzakas closed issue eslint/eslint#3484
@nzakas
Separate `quotes` rule for Object keys
nzakas commented on issue eslint/eslint#3484
@nzakas

I'm thinking this is best off as a custom rule for now. I don't see a big need for this in core.

nzakas commented on issue eslint/eslint#5183
@nzakas

Yes

nzakas commented on issue eslint/eslint#5060
@nzakas

overrides seems like a good way to solve it.

nzakas commented on issue eslint/eslint#5231
@nzakas

It will parse as just a description, not as a type. I'm not sure this is something we can fix because there's no good way for us to tell if somethi…

nzakas commented on issue eslint/eslint#5234
@nzakas

I don't think so. There's no limit to the number of items in the array. We'd just need to ensure that we don't assume any specific position for eac…

nzakas commented on issue eslint/eslint#5239
@nzakas

As far as I can tell, there's no bug here. In the first instance, you were resetting globalReturn to false, which made the rule enforce function st…

nzakas commented on issue eslint/eslint#5234
@nzakas

I like @guyellis's suggestion. Anyone want to submit a PR?

nzakas commented on issue eslint/eslint#5221
@nzakas

Hmmm, not sure I want automatic crash info sent to us. Ideally, a crash happens and we prevent people from opening issues because the error message…

nzakas deleted branch issue5223 at eslint/eslint
nzakas pushed to master at eslint/eslint
@nzakas
nzakas closed issue eslint/eslint#5223
@nzakas
Switch release process to use eslint-release
nzakas merged pull request eslint/eslint#5224
@nzakas
Build: Switch to using eslint-release (fixes #5223)
1 commit with 33 additions and 194 deletions
nzakas commented on issue eslint/eslint#5241
@nzakas

This is due to the change in how parser path is calculated. When oarser is provided, its path is calculated differently in 2.0.0 than in 1.x. We sh…

nzakas opened pull request eslint/eslint#5225
@nzakas
Docs: Add links for issue documentation
1 commit with 23 additions and 3 deletions
nzakas pushed to readme at eslint/eslint
@nzakas
  • @nzakas ae663b6
    Docs: Add links for issue documentation
nzakas created branch readme at eslint/eslint
nzakas opened pull request eslint/eslint#5224
@nzakas
Build: Switch to using eslint-release (fixes #5223)
1 commit with 33 additions and 194 deletions
nzakas created branch issue5223 at eslint/eslint
nzakas opened issue eslint/eslint#5223
@nzakas
Switch release process to use eslint-release
nzakas commented on issue eslint/eslint#3484
@nzakas

@ilyavolodin can you show an example?

nzakas commented on pull request eslint/doctrine#152
@nzakas

Looks like a pretty good approach to me. Can you reformat your commit summary to be: Update: Add support for slash in namepaths (fixes #100) Also,…

nzakas pushed to master at eslint/eslint
@nzakas
nzakas merged pull request eslint/eslint#5215
@nzakas
Docs: Remove inline errors from doc examples
1 commit with 1,024 additions and 1,047 deletions
nzakas closed issue eslint/eslint#4104
@nzakas
Remove inline errors from rule doc examples
nzakas commented on issue eslint/eslint.github.io#195
@nzakas

I was looking at parser.index.js....seems like that was generated somewhere else?

nzakas commented on issue eslint/eslint.github.io#196
@nzakas

Thanks!

nzakas commented on issue eslint/eslint#5221
@nzakas

Definitely worth investigating. If we could create an eslint-crash.log whenever there's a crash, and instruct users to paste that into an issue, th…

Something went wrong with that request. Please try again.