Nicholas C. Zakas
nzakas

Organizations

@eslint
Aug 24, 2016
@nzakas
  • @JamesHenry 7364cb9
    New: Add method decorators to AST (fixes #65) (#64)
Aug 24, 2016
@nzakas
New: Add method decorators to AST (fixes #65)
1 commit with 1,758 additions and 1 deletion
Aug 24, 2016
@nzakas
Add static and instance method decorators to the AST
Aug 24, 2016
nzakas commented on pull request eslint/typescript-eslint-parser#64
@nzakas

This looks great, nice work!

Aug 24, 2016
@nzakas

Agreed.

Aug 24, 2016
@nzakas

I just used astexplorer.net.

Aug 24, 2016
nzakas commented on issue eslint/eslint#6852
@nzakas

The config generator adds experimentalObjectRestSpread for React / JSX but this shouldn't be needed This is the correct behavior. People using Re…

Aug 24, 2016
nzakas pushed to master at eslint/eslint
@nzakas
  • @mysticatea 7660b39
    Fix: `object-curly-spacing` for type annotations (fixes #6940) (#6945)
Aug 24, 2016
nzakas merged pull request eslint/eslint#6945
@nzakas
Fix: `object-curly-spacing` for type annotations (fixes #6940)
1 commit with 1,263 additions and 3 deletions
Aug 24, 2016
nzakas closed issue eslint/eslint#6940
@nzakas
object-curly-spacing `[2, 'never']` complains of Flow type annotation in function parameters
Aug 24, 2016
nzakas commented on pull request eslint/eslint#6953
@nzakas

Lgtm, just a note on the docs. I don't think it's with putting the regular expression in the docs. It's hard to understand as it is, so better to …

Aug 24, 2016
nzakas commented on pull request eslint/eslint#6953
@nzakas

This section is supposed to be an introduction to the concept that the rule covers. It helps to show some examples and explain that some style guid…

Aug 24, 2016
@nzakas

That's a fair point.

Aug 24, 2016
@nzakas

@alexeagle thanks for the background info. While I can understand the concern about fragmentation, we are still planning to proceed here. From my p…

Aug 24, 2016
nzakas commented on pull request eslint/eslint#6942
@nzakas

Pushed an update. It's still not done, though I'm thinking it might be best to land something and then let people make incremental improvements rat…

Aug 24, 2016
@nzakas
  • @nzakas c609800
    Docs: Draft of JSCS migration guide (fixes #5859)
Aug 24, 2016
nzakas commented on pull request eslint/eslint#6942
@nzakas

I'm adding this now.

Aug 24, 2016
nzakas commented on pull request eslint/eslint#6942
@nzakas

I'll make those changes.

Aug 24, 2016
@nzakas

We could do that, though I'd want to tweak the implementation a bit. @alexeagle I think the overall point here is that ESLint is a lot more flexibl…

Aug 24, 2016
@nzakas

It could be, I just don't have the energy to do that at the moment. If you're interested, in seeing what could work for TypeScript, I'd happily rev…

Aug 23, 2016
nzakas commented on pull request eslint/eslint#6960
@nzakas

It depends on how easy it is to spot the problem. I think the concern here is that whitespace is hard to spot, so it makes sense to call it out as …

Aug 23, 2016
nzakas commented on pull request eslint/eslint#6960
@nzakas

This should be a regex check because there could also be a tab character or newline character, for example.

Aug 23, 2016
nzakas pushed to master at eslint/eslint
@nzakas
  • @mysticatea 3a1763c
    Fix: enable `@scope/plugin/ruleId`-style specifier (refs #6362) (#6939)
Aug 23, 2016
nzakas merged pull request eslint/eslint#6939
@nzakas
Fix: enable `@scope/plugin/ruleId`-style specifier (refs #6362)
1 commit with 96 additions and 28 deletions
Aug 23, 2016
nzakas commented on issue eslint/tsc-meetings#11
@nzakas

@platinumazure we don't have a choice here, we have to use the bot. I lobbied, successfully, to get the heuristic changed so that it only checks th…

Aug 23, 2016
nzakas commented on pull request jquery/jquery-license#70
@nzakas

Ping? Does anyone monitor this repo? We're still having a lot of trouble with this real name check on ESLint and it would be nice to get it fixed A…

Aug 22, 2016
nzakas commented on pull request eslint/typescript-eslint-parser#64
@nzakas

In Flow, the decorators array is always present even if empty. Probably best to do that here.

Aug 22, 2016
nzakas commented on pull request eslint/typescript-eslint-parser#64
@nzakas

Based on Flow, we don't need this extra node.

Aug 22, 2016
@nzakas

It looks like Flow does support decorators, and it's with the decorators array with Identifier or CallExpression as items, so probably best to mimi…

Aug 22, 2016
@nzakas

Makes sense. Bonus points for the animated demo. :)