Nicholas C. Zakas nzakas

Organizations

@eslint @todogroup
nzakas commented on pull request eslint/eslint#2888
@nzakas

Can you please prefix your commit message with "Docs:"? You can use git commit --amend and then git push -f to update your pull request.

nzakas pushed to master at eslint/eslint
@nzakas
nzakas merged pull request eslint/eslint#2881
@nzakas
Added missing export syntax support to the block-scoped-var rule. (fixes #2887)
1 commit with 24 additions and 0 deletions
nzakas closed issue eslint/eslint#2887
@nzakas
block-scoped-var false positives on some export constructions
nzakas commented on pull request eslint/eslint#2881
@nzakas

Ah, because it's invalid, it's different. :) This looks good, thanks!

nzakas commented on issue eslint/eslint#2865
@nzakas

No, we aren't going to merge failing tests, so they're of little use. Do others agree making such a change makes sense?

nzakas commented on issue eslint/eslint#2884
@nzakas

Can you please show an example of the problematic code and show the ESLint output? It's hard for others to understand what you're reporting without…

nzakas commented on pull request eslint/eslint#2883
@nzakas

I think you misunderstood the issue. The change was to add a "root" option to .eslintrc files that would say "don't continue to the parent director…

nzakas commented on pull request eslint/eslint#2883
@nzakas

Should be "set to true to stop configuration cascading from continuing to the parent directory"

nzakas commented on issue eslint/eslint#2517
@nzakas

Sounds good :)

nzakas commented on issue eslint/eslint#1983
@nzakas

@dotnil exactly what I was thinking

nzakas commented on issue babel/babel-eslint#136
@nzakas

Yikes! Okay, at some point I'll dig in and see what's going on there.

nzakas commented on pull request eslint/eslint#2881
@nzakas

Can you file a separate issue? Id like to keep these two discussions separate. Also, can please reformat your commit message to begin with "Fix:" p…

nzakas commented on issue eslint/eslint#2807
@nzakas

Are you using the default parser or babel-eslint?

nzakas commented on issue eslint/eslint#2807
@nzakas

This syntax is actually invalid and is a proposed addition to ES7: syntax, but that is part of the experimental https://github.com/leebyron/ecmascr…

nzakas commented on issue eslint/eslint#1898
@nzakas

These are the last tasks after the other 1.0.0 ones are complete. Agree it would be nice to document when rules were removed. We will need to keep …

nzakas commented on issue eslint/eslint#2203
@nzakas

Yup, just noticed auto configure, but have no idea how it works.

nzakas commented on pull request eslint/eslint#2869
@nzakas

Can you use options instead of args? It's the same except you don't need the 2 (which is never used anywhere). We are trying to deprecate args.

nzakas commented on issue eslint/eslint#1539
@nzakas

We've debated how to share amongst rules, and I think at some point we just need to go for it and see what happens, so that approach is fine by me. I…

nzakas commented on issue eslint/eslint#2865
@nzakas

My concern with what you have proposed is that let and const are block-scoped, so it doesn't really make sense to force them to be declared at the …

nzakas commented on issue babel/babel-eslint#136
@nzakas

What would be necessary in the ESLint side to prevent you from needing to monkey patch or otherwise load rules directly?

@nzakas
  • @nzakas c66eb5f
    Renaming exports and imports
@nzakas
  • @nzakas 63c0933
    Basic of exporting and importing
@nzakas
nzakas commented on issue eslint/eslint#2736
@nzakas

Awesome, thanks!

nzakas pushed to master at eslint/eslint
@nzakas
nzakas merged pull request eslint/eslint#2878
@nzakas
New: Add serviceworker environment (fixes #2557)
1 commit with 5 additions and 1 deletion
nzakas commented on pull request eslint/eslint#2878
@nzakas

LGTM

nzakas closed issue eslint/eslint#2877
@nzakas
Move TDZ errors to no-undef?
nzakas commented on issue eslint/eslint#2877
@nzakas

I disagree. Looking at it from a user's perspective, it makes more sense to say "You used x before it was defined" vs. "x is not defined". The goa…