Nicholas C. Zakas nzakas

Organizations

@eslint @todogroup
nzakas commented on issue eslint/eslint#2318
@nzakas

Ok, let's go with global-require as the rule name. You can either take a stab at it, or we can leave it open for implementation. New rules are very…

nzakas commented on issue eslint/eslint#2590
@nzakas

Er, test unhappy path

nzakas commented on issue eslint/eslint#2590
@nzakas

Yes, you have to read unhappy path - that's usually where bugs hide.

nzakas commented on issue eslint/eslint#2592
@nzakas

Ok, marking as a bug

nzakas commented on pull request eslint/eslint#2515
@nzakas

Lgtm,but my mind is mush, so someone else should double check :)

nzakas commented on issue eslint/eslint#2594
@nzakas

Yup

nzakas commented on issue eslint/eslint#2503
@nzakas

My concern is that this appears to require the spreadsheet to be publicly accessible, and I don't like that - I don't want to have a list of emails…

nzakas commented on issue eslint/eslint#2595
@nzakas

What do you think eslint-tester's job is in this regard? What are we trying to accomplish?

nzakas commented on pull request eslint/eslint#2591
@nzakas

I'm generally pretty weary of telling Istanbul to ignore things, so please double check that there's no good way to try, or if some code is unreach…

nzakas commented on issue eslint/eslint#1636
@nzakas

Updated

nzakas commented on pull request eslint/eslint#2593
@nzakas

Reminder: we need tests to verify all changes.

nzakas closed issue eslint/eslint#1016
@nzakas
space-infix-ops: relaxed version
nzakas commented on issue eslint/eslint#1016
@nzakas

Let's just close it - it's been open almost a year without any progress.

nzakas commented on issue eslint/eslint#2592
@nzakas

@ilyavolodin @gyandeeps have either of you confirmed that this is a bug?

nzakas commented on issue eslint/eslint#2594
@nzakas

Looks like a bug.

nzakas pushed to master at eslint/eslint
@nzakas
nzakas merged pull request eslint/eslint#2463
@nzakas
New: accessor-pairs rule to object initializations (fixes #1638)
1 commit with 290 additions and 0 deletions
nzakas commented on pull request eslint/eslint#2463
@nzakas

Lgtm

nzakas commented on issue eslint/eslint#2588
@nzakas

From what I can tell, there is no false positive here. It's a true positive because the third slash doesn't have a space before it. The third slash…

nzakas commented on issue eslint/eslint#2503
@nzakas

Looks like just the guts, not the actual not.

nzakas commented on pull request eslint/eslint#2179
@nzakas

Can you open an issue for that discussion? I'd like to get out conversation back on issues and close this.

nzakas closed issue eslint/eslint#987
@nzakas
Rule: logical expressions that always constant
nzakas commented on issue eslint/eslint#987
@nzakas

I agree. This has been open nearly a year and we aren't even close, so likely won't happen.

nzakas commented on issue eslint/eslint#2585
@nzakas

There's already a very clear separation of responsibilities in the repo: http://eslint.org/docs/developer-guide/architecture Not sure another modul…

nzakas closed issue eslint/eslint#2585
@nzakas
Trying to use eslint in browser
nzakas commented on issue eslint/eslint#2585
@nzakas

You can't use ESLint directly with webpack or browserify without modification. Your best bet is to check out the repo and run npm run browserify to…

nzakas pushed to master at eslint/eslint
@nzakas
nzakas merged pull request eslint/eslint#2586
@nzakas
Fix: counting of variables statements in one-var (fixes #2570)
1 commit with 24 additions and 2 deletions
nzakas commented on pull request eslint/eslint#2586
@nzakas

Lgtm

nzakas commented on pull request eslint/eslint#2476
@nzakas

I'll come back to this again: What exactly is the point of this rule? The initial description was for ASI (and your rule name indicates this), but …