Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong encoding in file names of downloaded files #137

Closed
hugbug opened this issue Dec 29, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Dec 29, 2015

NZBGet reads file names from articles. The names are part of yEnc-format. The format however lacks encoding information; it also doesn't support Unicode. In most cases however the file names are encoded in Latin1 or Windows-1252 and so should we treat them.

After the names are read from articles NZBGet uses them "as is", which is not correct. Internally all file names in program are represented in UTF8. The file names read from articles should be transcoded from Latin1/Windows-1252 to UTF8. This will ensure the files written to disk will have proper names.

Related forum topics:

@hugbug hugbug added the bug label Dec 29, 2015

@hugbug hugbug added this to the v17.0 milestone Dec 29, 2015

hugbug added a commit that referenced this issue Dec 29, 2015

#137: transcode file names read from articles
File names which were read from downloaded articles (yEnc) are now
transcoded from Latin1 to UTF8.

@hugbug hugbug closed this Dec 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.