New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install included scripts into default MainDir on Windows #145

Closed
hugbug opened this Issue Jan 5, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Member

hugbug commented Jan 5, 2016

The included demo scripts (EMail.py and Logger.py) are installed into directory scripts of NZBGet installation directory (typically C:\Program Files (x86)\NZBGet\scripts).

When the program starts for the first time it creates MainDir directory (typically **C:\ProgramData\NZBGet**) with required sub-directories and new configuration file. As part of this process directory scripts is created and scripts are copied there from installation directory.

This may lead to confusion (see #144). Another problem is that the scripts are not updated in C:\ProgramData\NZBGet\scripts on program updates and users continue to use old versions of scripts.

To solve both issues setup should copy pp-scripts directly into C:\ProgramData\NZBGet\scripts instead of C:\Program Files (x86)\NZBGet\scripts.

A special case: if destination directory contains file nzbget.conf, that means NZBGet is used in portable mode. In that case the scripts should be installed into installation directory (just like before).

@hugbug hugbug added the improvement label Jan 5, 2016

@hugbug hugbug added this to the v17.0 milestone Jan 5, 2016

hugbug added a commit that referenced this issue Apr 10, 2016

@hugbug hugbug closed this Apr 10, 2016

hugbug added a commit that referenced this issue Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment