Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error messages printed on DNS lookup errors #146

Closed
hugbug opened this issue Jan 8, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Jan 8, 2016

If a DNS error lookup error occurs the printed error messages are not correct, for example:

Could not resolve hostname xxxxxx.xx: ErrNo 2, No such file or directory.

This is due to incorrect usage of errno and strerror(). Errors reported by getaddrinfo() must be formatted into strings via special function gai_strerror().

This error doesn't affect Windows (on Windows always using another special function).

@hugbug hugbug added the improvement label Jan 8, 2016

@hugbug hugbug added this to the v17.0 milestone Jan 8, 2016

hugbug added a commit that referenced this issue Jan 8, 2016

#146: improved error reporting on DNS lookup errors
Previously printed error messages were not correct as errors must be
read via special function, not via default “errno”.

@hugbug hugbug closed this Jan 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.