New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Page in iOS Chrome is Broken #178

Closed
punkrockjack opened this Issue Mar 1, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@punkrockjack

punkrockjack commented Mar 1, 2016

If you open the UI page in iOS Chrome, you are greeted with the message:

"Error in http://(you_server_ip and port) (line 3)
ReferenceError: Can't find variable: fieldset"

and the page fails to auto-reload.

iOS: 9.2.1
iOS Chrome: 48.0.2564.104
nzbget: 16.4

Seems to be an error with multiple fieldset tags not enclosed in a form (https://bugs.chromium.org/p/chromium/issues/detail?id=570095)

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Mar 2, 2016

Member

If you can provide a fix (in form of pull request to develop branch) I'll be happy to merge it.

Member

hugbug commented Mar 2, 2016

If you can provide a fix (in form of pull request to develop branch) I'll be happy to merge it.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Mar 5, 2016

Member

OK. I've put form-tags around each fieldset-tag and it seems to not break anything on desktop browsers where I've tested it.

I can't test if it helps on iOS Chrome though. If you want to test it send me a note to nzbget@gmail.com and I'll send you the modified files.

I'm not going to commit the changed version until I have a confirmation that the fix works.

Member

hugbug commented Mar 5, 2016

OK. I've put form-tags around each fieldset-tag and it seems to not break anything on desktop browsers where I've tested it.

I can't test if it helps on iOS Chrome though. If you want to test it send me a note to nzbget@gmail.com and I'll send you the modified files.

I'm not going to commit the changed version until I have a confirmation that the fix works.

@hugbug hugbug closed this in 1d72899 Mar 12, 2016

@hugbug hugbug added this to the v17.0 milestone Mar 19, 2016

@punkrockjack

This comment has been minimized.

Show comment
Hide comment
@punkrockjack

punkrockjack Jun 21, 2016

This issue is back as of version 16.4-22 :(

punkrockjack commented Jun 21, 2016

This issue is back as of version 16.4-22 :(

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Jun 21, 2016

Member

This issue is back as of version 16.4-22 :(

What do you mean with "back"? It was fixed in v17 and not in v16.

Member

hugbug commented Jun 21, 2016

This issue is back as of version 16.4-22 :(

What do you mean with "back"? It was fixed in v17 and not in v16.

@punkrockjack

This comment has been minimized.

Show comment
Hide comment
@punkrockjack

punkrockjack Jun 21, 2016

Oh sorry! I totally forgot that I had test code that had the fix for this, which must've gotten wiped out when it got updated. My mistake!

punkrockjack commented Jun 21, 2016

Oh sorry! I totally forgot that I had test code that had the fix for this, which must've gotten wiped out when it got updated. My mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment