New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed articles #205

Closed
hugbug opened this Issue Apr 21, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@hugbug
Member

hugbug commented Apr 21, 2016

There is "Download again"-feature, which deletes already downloaded files and then redownloads from scratch.

It would be nice to be able to retry only failed articles without loosing already downloaded data. That could be useful for example after adding or activating of a new news server.

Prerequisites for this feature have been already implemented with quick par verification feature - the articles status information is hold for history items. That info can be used to determine which articles need to be redownloaded.

There is one limitation thought - the articles status data is not saved for deleted downloads being they deleted manually by user or automatically by health check. Therefore downloads failed due to health status (option HealthCheck=delete) cannot be partially retried. It's to decide later whether this limitation must be overcome.

Also see forum topic Download Again only the missing blocks / parts.

In this issue:

  • implement "retry failed articles" for failed downloads having article status data;
  • fix time-field for retried files;
  • decide what to do with HealthCheck=delete discarding article status data.

@hugbug hugbug added the feature label Apr 21, 2016

@hugbug hugbug added this to the v17.0 milestone Apr 21, 2016

hugbug added a commit that referenced this issue Apr 21, 2016

#205: retry failed articles
- new action in history dialog: retry failed articles;
- new command “HistoryRetryFailed” of RPC-method “editqueue”;
- new subcommand “F” of command line switch “-E/--edit” for history.

hugbug added a commit that referenced this issue May 12, 2016

#205: retry for deleted downloads too
Commands “Retry failed articles” and “Download remaining files“ now
work for deleted downloads too (including deleted by health check).

hugbug added a commit that referenced this issue May 12, 2016

#205: improved file state handling
Better handling of all cases: manual delete, health delete, retry
failed, download remaining with ContinuePartial=on/off and
DirectWrite=on/off.

hugbug added a commit that referenced this issue May 12, 2016

#205: new option "HistoryCleanupDisk"
… extracted from “DeleteCleanupDisk”.
@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug May 14, 2016

Member

Health check and "retry failed articles"

decide what to do with HealthCheck=delete discarding article status data.

Now, when option DeleteCleanupDisk=no (which is a default setting now), the information about downloaded files and articles is kept in history when a download item is deleted manually or by health check. For such history items commands "Retry failed articles" and "Download remaining files" are available in history.

Previously option "DeleteCleanupDisk" also controlled wether the downloaded files of failed downloads should be deleted when a history item is deleted or hidden. This behavior is almost always wanted. In order to provide this function independent of option "DeleteCleanupDisk" a new option was introduced - "HistoryCleanupDisk".

Member

hugbug commented May 14, 2016

Health check and "retry failed articles"

decide what to do with HealthCheck=delete discarding article status data.

Now, when option DeleteCleanupDisk=no (which is a default setting now), the information about downloaded files and articles is kept in history when a download item is deleted manually or by health check. For such history items commands "Retry failed articles" and "Download remaining files" are available in history.

Previously option "DeleteCleanupDisk" also controlled wether the downloaded files of failed downloads should be deleted when a history item is deleted or hidden. This behavior is almost always wanted. In order to provide this function independent of option "DeleteCleanupDisk" a new option was introduced - "HistoryCleanupDisk".

@hugbug hugbug closed this May 14, 2016

hugbug added a commit that referenced this issue May 15, 2016

#205: improved handling of queue cleanup
Also removed option “ParCleanupQueue” as it is not needed anymore with
reworked state handling.

hugbug added a commit that referenced this issue May 16, 2016

#205: fixed: nzb-log was deleted
… just before adding to history

hugbug added a commit that referenced this issue Oct 9, 2017

#205: retry failed articles
- new action in history dialog: retry failed articles;
- new command “HistoryRetryFailed” of RPC-method “editqueue”;
- new subcommand “F” of command line switch “-E/--edit” for history.

hugbug added a commit that referenced this issue Oct 9, 2017

#205: retry for deleted downloads too
Commands “Retry failed articles” and “Download remaining files“ now
work for deleted downloads too (including deleted by health check).

hugbug added a commit that referenced this issue Oct 9, 2017

#205: improved file state handling
Better handling of all cases: manual delete, health delete, retry
failed, download remaining with ContinuePartial=on/off and
DirectWrite=on/off.

hugbug added a commit that referenced this issue Oct 9, 2017

#205: new option "HistoryCleanupDisk"
… extracted from “DeleteCleanupDisk”.

hugbug added a commit that referenced this issue Oct 9, 2017

#205: improved handling of queue cleanup
Also removed option “ParCleanupQueue” as it is not needed anymore with
reworked state handling.

hugbug added a commit that referenced this issue Oct 9, 2017

#205: fixed: nzb-log was deleted
… just before adding to history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment