Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options when deleting downloads #224

Closed
hugbug opened this issue May 29, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@hugbug
Copy link
Member

commented May 29, 2016

When implementing #205 a new option HistoryCleanupDisk was added. Now the behavior of deleting of already downloaded files is controlled by two options DeleteCleanupDisk and HistoryCleanupDisk. Although there are two options it is still not very clear when the already downloaded files are deleted and when not.

To make it simpler and alternative solution is proposed:

  • remove options DeleteCleanupDisk and HistoryCleanupDisk;

  • in the "delete downloads dialog" allow user to decide if the already downloaded files must be deleted or not. That's how the dialog may look like:
    screen shot 2016-05-29 at 12 19 32

    The new dialog will explain for each option what happens with already downloaded files.

  • option HealthCheck will be extended with new possible value Park now offering:

    • Delete - to move download into history and delete already downloaded files;
    • Park - to move download into history and keep already downloaded files.
  • when download is removed from history (manually by user or automatically after KeepHistory days) the already downloaded files will be deleted (without option);

@hugbug hugbug added the feature label May 29, 2016

@hugbug hugbug added this to the v17.0 milestone May 29, 2016

hugbug added a commit that referenced this issue May 29, 2016

hugbug added a commit that referenced this issue May 29, 2016

@hugbug hugbug closed this May 30, 2016

@joshuacant

This comment has been minimized.

Copy link

commented Aug 24, 2016

Hi, is commenting here the right way to provide feedback? Not sure. Guess I'll do it and see what happens...

These new options should also appear when managing items from the history page. In build r1756 if there's a failed download I'd like to keep history of but delete the files, I have to pause the main queue, move the download back by picking "retry failed articles". Then, from the download page, I can delete the files while keeping history.

Thanks, and apologies if this is the wrong place for this sort of feedback.

@hugbug

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2016

Wouldn't it be strange if command Delete in history would not delete the history item?

Why don't you just Delete items from history and choose "hide" option (default)? The files are deleted amd you still can see the hidden item if necessary. This also happens automaticaly after the KeepHistory days. So the disk space is cleaned up automatically for failed downloads.

@joshuacant

This comment has been minimized.

Copy link

commented Aug 24, 2016

Ah, okay, then maybe the dialog box on the History tab just needs a little tweaking. Currently it says: "Selected records will be deleted from history. All files remain on disk."

Thanks for taking the time to reply to my comment, I know that your time is valuable.

@hugbug

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2016

You are right, the text is wrong and wasn't updated for v17. I'm opening the issue to fix this.
Thank you to bring this to my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.