New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard support in web-interface #242

Closed
hugbug opened this Issue Jul 19, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@hugbug
Member

hugbug commented Jul 19, 2016

Currently web-interface does not have a special keyboard support other than the default one provided by browser. Moreover an extra code was written to prevent browser of processing Enter-keys (#237).

This issue is about improving keyboard support which includes:

  • Enter key in dialogs should be processed as a click on the default button;
  • keyboard shortcuts should be provided for navigation through paginated lists (see related #240).

Question to all users: do we need keyboard shortcuts for other things?

@mannibis

This comment has been minimized.

Show comment
Hide comment
@mannibis

mannibis Jul 22, 2016

I think it would be cool to have keyboard shortcuts for the items under the Actions menu in the pop-up screen for History items. Like, pressing "p" for Post-Process Again, or "d" for Download Again

mannibis commented Jul 22, 2016

I think it would be cool to have keyboard shortcuts for the items under the Actions menu in the pop-up screen for History items. Like, pressing "p" for Post-Process Again, or "d" for Download Again

@deanishe

This comment has been minimized.

Show comment
Hide comment
@deanishe

deanishe Jul 26, 2016

Moreover an extra code was written to prevent browser of processing Enter-keys

In 17.0-testing-r1726 this is not the case for the Speed Limit dialog. It accepts an ENTER keypress but sends you to your.server.address/?#, which is a 404.

deanishe commented Jul 26, 2016

Moreover an extra code was written to prevent browser of processing Enter-keys

In 17.0-testing-r1726 this is not the case for the Speed Limit dialog. It accepts an ENTER keypress but sends you to your.server.address/?#, which is a 404.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Jul 26, 2016

Member

It's in the latest testing, which is r1735.

Member

hugbug commented Jul 26, 2016

It's in the latest testing, which is r1735.

@deanishe

This comment has been minimized.

Show comment
Hide comment
@deanishe

deanishe Jul 26, 2016

Just updated to r1735. ESC closes dialogs, ENTER has no effect.

Is that intended?

I'm running OS X 10.11.5 and tried Safari and Chrome.

deanishe commented Jul 26, 2016

Just updated to r1735. ESC closes dialogs, ENTER has no effect.

Is that intended?

I'm running OS X 10.11.5 and tried Safari and Chrome.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Jul 26, 2016

Member

Is that intended?

Yes (as long as this issue is open; Enter will work when the feature is implemented).

Member

hugbug commented Jul 26, 2016

Is that intended?

Yes (as long as this issue is open; Enter will work when the feature is implemented).

@deanishe

This comment has been minimized.

Show comment
Hide comment
@deanishe

deanishe Jul 26, 2016

Right you are. Thanks for the explanation!

deanishe commented Jul 26, 2016

Right you are. Thanks for the explanation!

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Jul 26, 2016

Member

@mannibis:
Like, pressing "p" for Post-Process Again, or "d" for Download Again

I think one-key-shortcuts are bad. For example in Firefox direct typing means "search on page". In NZBGet we also have a search box at the top of the page. One-key-shortcuts should not work when the search box is focused.

I don't know which key combinations are best for web pages, since different OS have different standards for shortcuts. Will need to learn best practices.

Any advice will be appreciated.

Member

hugbug commented Jul 26, 2016

@mannibis:
Like, pressing "p" for Post-Process Again, or "d" for Download Again

I think one-key-shortcuts are bad. For example in Firefox direct typing means "search on page". In NZBGet we also have a search box at the top of the page. One-key-shortcuts should not work when the search box is focused.

I don't know which key combinations are best for web pages, since different OS have different standards for shortcuts. Will need to learn best practices.

Any advice will be appreciated.

@hugbug hugbug added this to the v18 milestone Aug 8, 2016

@hugbug hugbug added the help wanted label Sep 9, 2016

@hugbug hugbug removed the help wanted label Nov 17, 2016

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Nov 20, 2016

Member

Article J, K, or How to choose keyboard shortcuts for web applications has good tips.

Basically web-apps should use only single letters as shortcuts to avoid conflicts with browser shortcuts. I allowed me also usage of Shift+Letter and Arrows.

Implemented shortcuts in NZBGet

See new wiki-page Keyboard shortcuts for details.

Member

hugbug commented Nov 20, 2016

Article J, K, or How to choose keyboard shortcuts for web applications has good tips.

Basically web-apps should use only single letters as shortcuts to avoid conflicts with browser shortcuts. I allowed me also usage of Shift+Letter and Arrows.

Implemented shortcuts in NZBGet

See new wiki-page Keyboard shortcuts for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment