Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtCleanupDisk Can't be disabled per NZB Task #249

Closed
DominicMe opened this issue Jul 31, 2016 · 6 comments

Comments

@DominicMe
Copy link

commented Jul 31, 2016

As it stand NZBGet 17.0 deletes all files listed in ExtCleanupDisk option even when post-processing and unpacking is disabled for a specific nzb job. This means it is impossible to download any files with extensions matching ExtCleanupDisk options without removing that extensions and reloading NZBGet. This is a bug or otherwise a terrible design flaw.

The fix can be to either disable cleanup when unpacking is disabled or to add an option to disable the ExtCleanupDisk per nzb job.

@DominicMe DominicMe changed the title ExtCleanupDisk Executes even when Unpack disabled ExtCleanupDisk Can't be disabled per NZB Task Jul 31, 2016

@hugbug

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

ExtCleanupDisk is for files you never want, for example .nfo or .sfv, regardless of unpack.

If you need more flexible cleanup you can always write a simple post-processing script like:

#! /bin/sh
### NZBGET POST-PROCESSING SCRIPT
rm -f *nfo *.sfv

You can create different scripts and use them for different nzbs.

@DominicMe

This comment has been minimized.

Copy link
Author

commented Jul 31, 2016

The problem is that there are always circumstances where you may need files that you normally don't, even .sfv and .nfo

Wouldn't it make sense to have an option to enable/disable ExtCleanupDisk option in the same as UnpackCleanupDisk? I mean if you don't want the files unpacked you probably don't want anything removed. As it is stands now there is simply no way to download all original files unless you don't use ExtCleanupDisk option at all.

@hugbug

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

Wouldn't it make sense to have an option to enable/disable ExtCleanupDisk option in the same as UnpackCleanupDisk?

Don't understand what you mean.

Maybe you mean if per-nzb parameter "Unpack" is disabled then the cleanup should not be done as well? That sounds reasonable.

@DominicMe

This comment has been minimized.

Copy link
Author

commented Jul 31, 2016

I mean that there should be a way to enable/disable ExtCleanupDisk parameter just like UnpackCleanupDisk. That would allow to enable or disable ExtCleanupDisk without deleting (possibly) a long list of extensions. This is a minor issue though. The solution the primary issue is like you said to disable ExtCleanupDisk when "Unpack" is disabled either per-nzb or globally.

@hugbug

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

Well, it doesn't make sense for me to have an option to disable another option.

@DominicMe

This comment has been minimized.

Copy link
Author

commented Jul 31, 2016

ExtCleanupDisk is more like a list of options as you can add as many as you want. It would be a convenience when you have a long list that would want to disable temporarily. Not really a big deal to be honest.
If ExtCleanupDisk is disabled when Unpack is disabled I'm happy :)

@hugbug hugbug added the feature label Jul 31, 2016

@hugbug hugbug added this to the v18 milestone Jul 31, 2016

@hugbug hugbug added improvement and removed feature labels Sep 9, 2016

hugbug added a commit that referenced this issue Sep 19, 2016
#249: do not cleanup if unpack disabled
If parameter "unpack" is disabled for an nzb-file the cleanup isn't
performed for it.

@hugbug hugbug closed this Sep 19, 2016

hugbug added a commit that referenced this issue Oct 9, 2017
#249: do not cleanup if unpack disabled
If parameter "unpack" is disabled for an nzb-file the cleanup isn't
performed for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.