New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show password-badge for nzbs with passwords #274

Closed
hugbug opened this Issue Sep 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@hugbug
Member

hugbug commented Sep 9, 2016

For nzbs having password set on tab "postprocess" it would be nice to have badge "passworded", "protected", "encrypted" or similar (not sure which one) displayed in the queue and history lists.

A mouseover-hint could show the password itself.

@guaguasi

This comment has been minimized.

Show comment
Hide comment
@guaguasi

guaguasi Sep 19, 2016

Contributor

I just did this.

How would you want mouseover-hint done? I thought about using the bootstrap tooltip, but I'd have to write a click handler and manually launch the tooltip since Bootstrap 2.0.3 doesn't have any other trigger options. The placement would also need to be changed depending on the layout. Not exactly the most elegant, but easily doable. I could also just append : <password> to the label on click (and/or hover). Simplest solution would be to just add a title attribute but that wouldn't be visible on mobile.

Contributor

guaguasi commented Sep 19, 2016

I just did this.

How would you want mouseover-hint done? I thought about using the bootstrap tooltip, but I'd have to write a click handler and manually launch the tooltip since Bootstrap 2.0.3 doesn't have any other trigger options. The placement would also need to be changed depending on the layout. Not exactly the most elegant, but easily doable. I could also just append : <password> to the label on click (and/or hover). Simplest solution would be to just add a title attribute but that wouldn't be visible on mobile.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 19, 2016

Member

I meant the title-attribute. Doesn't work on mobile, yes, but that's just a little bonus feature for desktop.

Member

hugbug commented Sep 19, 2016

I meant the title-attribute. Doesn't work on mobile, yes, but that's just a little bonus feature for desktop.

@hugbug hugbug closed this Sep 23, 2016

hugbug added a commit that referenced this issue Oct 4, 2016

#274: fixed error on history page
Fixed javascript error on history page when showing hidden items.

hugbug added a commit that referenced this issue Oct 9, 2017

#274: fixed error on history page
Fixed javascript error on history page when showing hidden items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment