Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-method "editqueue" #299

Closed
hugbug opened this issue Oct 31, 2016 · 0 comments

Comments

@hugbug
Copy link
Member

commented Oct 31, 2016

API-method editqueue has signature:

bool editqueue(string Command, int Offset, string EditText, int[] IDs) 

From over 50 supported commands (parameter Command) only two use parameter Offset, all other commands receive extra arguments via parameter EditText).

To make the method more general the following change is to made: remove parameter Offsetand for two commands requiring offset argument pass it via parameter EditText (as string), which we should also rename to more general Args. The new signature will look like this:

bool editqueue(string Command, string Args, int[] IDs) 

For backward compatibility the old signature will be supported as well but declared as deprecated.

@hugbug hugbug added this to the v18 milestone Oct 31, 2016

hugbug added a commit that referenced this issue Oct 31, 2016
#299: removed parameter "offset" from api-method "editqueue"
When needed the “offset” is now passed within parameter “Args” as
string.

@hugbug hugbug closed this Oct 31, 2016

hugbug added a commit that referenced this issue Oct 9, 2017
#299: removed parameter "offset" from api-method "editqueue"
When needed the “offset” is now passed within parameter “Args” as
string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.