Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing category (and destination path) during direct unpack #408

Closed
hugbug opened this issue Jul 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Jul 2, 2017

If category is changed for nzb when direct unpack is running and that category change means change of destination path for that nzb the direct unpack continues but the unpacked files are not used during post-processing. As a result the default unpack modules performs unpacking again and the computer resources were wasted during direct unpack. The files unpacked by direct unpack remain in the old destination path.

In this issue:
Although it is technically possible to use the unpacked files despite the change of destination path, there are still many hitches in the way. Therefore for the sake of easiness the following behaviour is proposed: if destination path is changed during direct unpack the direct unpack should abort (and cleanup); the files will be unpacked during post-processing.

@hugbug hugbug added the bug label Jul 2, 2017

@hugbug hugbug added this to the v19.x milestone Jul 2, 2017

hugbug added a commit that referenced this issue Jul 2, 2017

#408: abort direct unpack if destination path was changed
For example caused by a change of category during direct unpack.

@hugbug hugbug closed this Jul 2, 2017

hugbug added a commit that referenced this issue Oct 9, 2017

#408: abort direct unpack if destination path was changed
For example caused by a change of category during direct unpack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.