New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test connection in webui succeeds if username or password are not provided #433

Closed
hugbug opened this Issue Aug 27, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@hugbug
Member

hugbug commented Aug 27, 2017

When testing connections from settings page the username/password are not validated because news servers usually don't request authorisation directly after connecting but rather later when downloading data, which isn't happening when testing connection.

This must be improved.

@hugbug hugbug added the improvement label Aug 27, 2017

@hugbug hugbug added this to the v20 milestone Aug 27, 2017

@hugbug hugbug changed the title from Test connection in webui doesn't check username and password to Test connection in webui succeeds if username or password are not provided Aug 27, 2017

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Aug 27, 2017

Member

Well, the username/password are actually checked if they are set in settings.
If however username or password is missing the connection test succeeds as long as the server is reachable, without authentication attempt. That's what must be improved.

Member

hugbug commented Aug 27, 2017

Well, the username/password are actually checked if they are set in settings.
If however username or password is missing the connection test succeeds as long as the server is reachable, without authentication attempt. That's what must be improved.

hugbug added a commit that referenced this issue Aug 27, 2017

#433: better username/password validation
when testing connection on settings page

@hugbug hugbug closed this Aug 27, 2017

hugbug added a commit that referenced this issue Oct 9, 2017

#433: better username/password validation
when testing connection on settings page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment