Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete or less useful options #461

Closed
hugbug opened this issue Oct 28, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Oct 28, 2017

Some options became less useful over years and can be completely removed:

  • SaveQueue and ReloadQueue - users expect the queue to be preserved on program restart. For a rare case if that is not desired the queue can be deleted manually before starting the program.
  • TerminateTimeout - this option controls when a hanging download thread must be killed. On one side this is very dangerous. On other side this should never be necessary as option ArticleTimeout should reset connection.
  • AccurateRate - it significantly increases CPU load but provide no real benefits.
  • BrokenLog - broken log cannot be viewed from web-interface and therefore most users will never see it; moreover the same info (and much more) can be viewed in per-nzb log (option NzbLog), which is accessible from web-interface. That made broken log obsolete.

Also:

  • rename option LogBufferSize to LogBuffer (just a nicer name).

@hugbug hugbug added the improvement label Oct 28, 2017

@hugbug hugbug added this to the v20 milestone Oct 28, 2017

hugbug added a commit that referenced this issue Oct 28, 2017

hugbug added a commit that referenced this issue Oct 29, 2017

#461: removed option "TerminateTimeout"
No thread killing anymore. Hanging downloads are gracefully cancelled
after timeout set in “ArticleTimeout” or “UrlTimeout”.

hugbug added a commit that referenced this issue Oct 29, 2017

hugbug added a commit that referenced this issue Oct 29, 2017

hugbug added a commit that referenced this issue Oct 29, 2017

#461: renamed option "LogBufferSize" to "LogBuffer"
and removed obsolete options “SaveQueue” and “ReloadQueue” from
config-file

@hugbug hugbug closed this Oct 29, 2017

hugbug added a commit that referenced this issue Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.