Force par-check for nzbs without archives #525
Comments
I consider non-archive posts to be a rare thing which isn't worth a special solution. Anyway you can set ParCheck=always and ParQuick=yes and you'll have the files always (quickly) verified. |
Thanks for your fast reply! Disagree on them being that rare:
If you don't want do to anything special, do you consider ParCheck=always and ParQuick=yes too be cheap enough to make them default similar to SABnzbd 2.3.2? |
Anime is what I mean with rare ;) Most users download movies and episodes. Non-archive posts was the future 10 years ago too, yet all posts are still archived (expect the rar ones from certain circles). The purpose of ParCheck=auto is to avoid unnecessary work (even small work). Making ParCheck=always by default isn't good as the vast majority of users don't need it. Even users who download anime must have very bad luck to fall into the case where ParCheck=auto wouldn't catch the corruption. Have you had such failures in NZBGet or is this an imaginary case (in which case the solution with ParCheck=always is good enough)? If you can convince me that such failures happen in NZBGet in real life I'll consider implementing the feature you are asking. Especially if you have logs of failed downloads; I mean real downloads, not some artificially modified nzb-files causing failures. Fair? |
Can't have the superior future when tools aren't ready. It's a chicken and egg problem. Sic TLS where SABnzbd and NZBGet made a change for the better.
Yes, incomplete NZBs happen.
In some cases par2 is already part of the NZB and could verify files.
Here's some incomplete post that would be par2 recoverable: Crashes and dropped internet connections that lead to incomplete posts still do happen in the real world.
Corollary for archive posts: |
Implemented in develop for v21. If you want to give it a try (and you don't compile yourself) - send me a note to nzbget@gmail.com with info about your platform and I'll send you current development version. |
Use-case
Usenet post consisting of a single multimedia file and PAR2-set.
Current behaviour
NZBGet 19.1 does not verify a single multimedia file by default (ParCheck: Auto) even tho CRC checksum for it exists in the main PAR2. ParQuick could verify it in little time.
Just relying on Yenc checksums of segments is not enough because:
So you might end up with a silently corrupted multimedia file, which might even play at first but then glitches.
Expected behaviour
Same behaviour as for archived files (at least RAR4/5) which verify CRC of the files (while unpacking).
Possible solution
ParQuick always verifies non-archived files such as a single multimedia file.
Current Workaround
Set ParCheck to Always.
But then you do two CRC verifications of the same file if it's archived because archives have their own CRC checksums (at least RAR4/5).
N.b. that's what SABnzbd 2.3.2 does by default.
The text was updated successfully, but these errors were encountered: