Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting active par-job may crash the program #527

Closed
hugbug opened this issue Apr 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Apr 2, 2018

There is a race condition which may cause crash when active par-job is deleted. This is very difficult to reproduce but I've got a crash dump from a real user. After a lot of attempts I was able to reproduce the issue.

The probability of crash is increasing when the program becomes paused at the very beginning of par-check process (although it's again not so easy to catch that moment). With a code change which was automatically (artificially) pausing the program as soon as par-check was started, I was able to reproduce the crash every time.

The fix is to add missing synchronisation when accessing the par-object from multiple threads.

@hugbug hugbug added the bug label Apr 2, 2018

@hugbug hugbug added this to the v20 milestone Apr 2, 2018

@hugbug hugbug closed this in c2669b3 Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.