Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Deleting active par-job may crash the program #527
There is a race condition which may cause crash when active par-job is deleted. This is very difficult to reproduce but I've got a crash dump from a real user. After a lot of attempts I was able to reproduce the issue.
The probability of crash is increasing when the program becomes paused at the very beginning of par-check process (although it's again not so easy to catch that moment). With a code change which was automatically (artificially) pausing the program as soon as par-check was started, I was able to reproduce the crash every time.
The fix is to add missing synchronisation when accessing the par-object from multiple threads.