Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Crash when flushing article cache after direct rename #529
Got crash dumps from a user where crashes occurred during flushing of article cache. The program state was "impossible" and it took a fair amount of time (three months) to collect these crash dumps and analyse them. Only after the third crash dump I finally got an idea of what was happening.
The critical place is in direct renamer: after renaming a small amount of data downloaded from par2-files is discarded (one article per par2-file) to avoid holding of info for these files, which are rarely used at all (par2-files are needed only for repair). It turned out the discarding of data isn't properly synchronised. As a result the article cache may attempt to write the data which was just deleted from memory.
A proper synchronisation must be developed.