Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for password protected archives #54

Closed
hugbug opened this issue Jul 11, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Jul 11, 2015

Problem

Password protected rar4-archives do not have a password validation record like rar5-archives. If extraction of rar4-archives fail, it's not clear whether the password is incorrect or the archive is corrupted.

In such cases NZBGet performs par-check in an attempt to repair the archive. If the par-check reports status "success, no repair necessary" NZBGet prints an unpack error:

Unpack for failed: second unpack attempt skipped due to par-check not repaired anything

It seems the message is misleading because the users don't know in details how the archives are processed and they wonder: "why the hell the unpack was skipped and why par-check didn't repair anything?"

Request

Change the message to something more understandable for normal users.

@hugbug

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2015

Two messages are printed now:

INFO Second unpack attempt skipped for due to par-check not repaired anything
ERROR Unpack for failed: checksum error in the encrypted file. Corrupt file or wrong password."

The ERROR-message is the one users look into. The message about second unpack attempt is printed as INFO and doesn't catch one's eye but is still helpful for advanced users.

@hugbug hugbug closed this Jul 11, 2015

@hugbug hugbug added the feature label Jul 25, 2015

@hugbug hugbug added this to the v16.0 milestone Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.