Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve error message for password protected archives #54
Password protected rar4-archives do not have a password validation record like rar5-archives. If extraction of rar4-archives fail, it's not clear whether the password is incorrect or the archive is corrupted.
In such cases NZBGet performs par-check in an attempt to repair the archive. If the par-check reports status "success, no repair necessary" NZBGet prints an unpack error:
It seems the message is misleading because the users don't know in details how the archives are processed and they wonder: "why the hell the unpack was skipped and why par-check didn't repair anything?"
Change the message to something more understandable for normal users.
Two messages are printed now:
The ERROR-message is the one users look into. The message about second unpack attempt is printed as INFO and doesn't catch one's eye but is still helpful for advanced users.