Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate inner file detection for same subjects #547

Closed
hugbug opened this issue May 31, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented May 31, 2018

Sometimes badly constructed nzbs include duplicate files. In such case the same inner file (such as archive part) is listed twice in nzb. This may happen if some files were not uploaded correctly and were reposted. NZBGet detects such duplicates and takes only the file with biggest size.

I've got an example nzb where all included files have the same name. That name wasn't obviously the actual file name. Real files names were stored in article bodies and read by nzbget during downloading. The duplicate detection however considered the files to be duplicates to each other and removed all except one.

This needs to be improved. Duplicate check should count files with the same name and consider them duplicates only if two files have same name but not more than two. This will cover both use cases.

@hugbug hugbug added the bug label May 31, 2018

@hugbug hugbug added this to the v20 milestone May 31, 2018

hugbug added a commit that referenced this issue May 31, 2018

@hugbug hugbug closed this May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.