New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining files splitted via par2 may fail due to renaming #595

Closed
hugbug opened this Issue Jan 2, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

hugbug commented Jan 2, 2019

If download contains splitted files which must be joined via par-repair process the joining may fail if the splitted files themselves are renamed.

That’s an unfortunate combination of options ParRename (DirectRename) and ParScan.

The repair works if both ParRename and DirectRename are disabled OR if ParScan=Full.

Otherwise the par-rename (or direct-rename) renames first part to its correct file name. Then during par-repair all other files are not scanned (this is an optimisation to speed up post-processing) because the only file belonging to par2-set exists and was already scanned, no reason to scan any other files (unless ParScan=Full).

To fix this without loosing performance optimisation (avoid scanning of all files when ParScan != Full) such cases should be taken care of specifically.

@hugbug hugbug added the improvement label Jan 2, 2019

hugbug added a commit that referenced this issue Jan 15, 2019

#595: functional tests for par-join issue
Some tests are failing because the issue isn’t fixed yet.

hugbug added a commit that referenced this issue Jan 16, 2019

hugbug added a commit that referenced this issue Jan 17, 2019

#595: functional tests for par-join issue
Some tests are failing because the issue isn’t fixed yet.

@hugbug hugbug added this to the v21 milestone Jan 18, 2019

@hugbug hugbug closed this Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment