New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM integration #604

Closed
hugbug opened this Issue Jan 17, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

hugbug commented Jan 17, 2019

Thanks to #582 I now know about lgtm.com, a code analysis tool, which can integrate with GitHub and is free for open source projects.

For proper analysis the integration has to be configured:

  • enable pull request analysis;
  • create proper configuration file in nzbget repository. This is needed at least to exclude library files from results;
  • fix alerts for C++;
  • fix alerts for JavaScript.

@hugbug hugbug added the meta label Jan 17, 2019

@hugbug hugbug added this to the v21 milestone Jan 17, 2019

hugbug added a commit that referenced this issue Jan 17, 2019

hugbug added a commit that referenced this issue Jan 17, 2019

hugbug added a commit that referenced this issue Jan 17, 2019

hugbug added a commit that referenced this issue Jan 18, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

#604: suppress an LGTM alert
A false positive.

hugbug added a commit that referenced this issue Jan 19, 2019

hugbug added a commit that referenced this issue Jan 19, 2019

@hugbug hugbug closed this Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment