Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curses client not displaying current download rate #610

Closed
KonaBlend opened this issue Feb 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@KonaBlend
Copy link

commented Feb 13, 2019

21.0-testing-r2296

curses frontend does not display current download rate. Traced the problem to server-side and there's an over-write of m_downloadRate with SpeedLimit which should be removed. This fixed my issue.

diff --git a/daemon/remote/BinRpc.cpp b/daemon/remote/BinRpc.cpp
index 5e351545..3ff32cac 100644
--- a/daemon/remote/BinRpc.cpp
+++ b/daemon/remote/BinRpc.cpp
@@ -675,7 +675,6 @@ void ListBinCommand::Execute()
 		Util::SplitInt64(remainingSize, &sizeHi, &sizeLo);
 		ListResponse.m_remainingSizeHi = htonl(sizeHi);
 		ListResponse.m_remainingSizeLo = htonl(sizeLo);
-		ListResponse.m_downloadRate = htonl(g_WorkState->GetSpeedLimit());
 		ListResponse.m_downloadPaused = htonl(g_WorkState->GetPauseDownload());
 		ListResponse.m_postPaused = htonl(g_WorkState->GetPausePostProcess());
 		ListResponse.m_scanPaused = htonl(g_WorkState->GetPauseScan());

hugbug added a commit that referenced this issue Feb 13, 2019

@hugbug hugbug added this to the v21 milestone Feb 13, 2019

@hugbug hugbug added the testing-bug label Feb 13, 2019

@hugbug

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Thank you.

Fixed.

@hugbug hugbug closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.