Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: AuthorizedIP range and or subnet notation #620

Closed
tastyratz opened this issue Mar 9, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@tastyratz
Copy link

commented Mar 9, 2019

I want to allow my entire local network to be an authorized ip without typing in all of the many ip's it could be individually.

I am not really sure why this hasn't always been the case, but, I wanted to file a request for it as it seems necessary for consistency when using DHCP at home.
I want password control with access outside of the local subnet, but not inside it.

@hugbug

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

The easiest would be to support wildcards like this:

AuthorizedIP=127.0.0.1,192.168.0.*

or even:

AuthorizedIP=127.0.0.1,192.168.*.*

Would it be enough? Support for ranges and subnets requires special implementation whereas wildcards can be implemented with two lines of code (worked fine in my short test).

@hugbug hugbug added the improvement label Mar 10, 2019

@hugbug hugbug added this to the v21 milestone Mar 10, 2019

@tastyratz

This comment has been minimized.

Copy link
Author

commented Mar 10, 2019

Wildcards are wildly better, that's fantastic! Anything to avoid having to type out the whole dhcp range.

@anoma

This comment has been minimized.

Copy link

commented Mar 10, 2019

Perhaps a built in selectable IANA private IP filter might help a lot of people specifically since 172.16.0.0 – 172.31.255.255 is a bit ugly to do with wildcards (it could hide the uglyness).

@hugbug

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@anoma, that's too much work for little gain.

The main purpose of the option is to login from local host. An ability to add other hosts is a bonus. Wildcards should cover most cases. And if they don't - any browser can save the password, you need to type it only once anyway.

hugbug added a commit that referenced this issue Mar 10, 2019

@hugbug

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Implemented wildcards.

@hugbug hugbug closed this Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.