Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search capabilities #72

Closed
hugbug opened this issue Aug 13, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@hugbug
Copy link
Member

commented Aug 13, 2015

Currently the search box can search for any word from the typed phrase.
An attempt to improve the search capabilities was made in #36 but it doesn't work very well.
quickfilter

Task: implement a proper parser with OR, AND, NOT, parenthesis and ability to search throw specified fields.

  • implement advanced parser;
  • make the parser default for all existing lists;
  • search specific fields;
  • create documentation page;
  • advanced search in settings.

@hugbug hugbug added the feature label Aug 13, 2015

hugbug added a commit that referenced this issue Aug 13, 2015

#72: made search engine pluggable
the default search engine is words-searcher (the old one).

hugbug added a commit that referenced this issue Aug 13, 2015

#72: removed search option "CaseSensitive"
it was always set to false anyway.

hugbug added a commit that referenced this issue Aug 13, 2015

@hugbug hugbug added this to the v16.0 milestone Aug 13, 2015

hugbug added a commit that referenced this issue Aug 14, 2015

#72: replaced jison-generated parser with own
- rewritten the parser manually;
- greatly reduced file size;
- better handling of errors;
- supports non-ascii characters.

hugbug added a commit that referenced this issue Aug 14, 2015

#72: integrated advanced search into module "tasttable"
- removed old word-search default search engine;
- the new advanced search is always used now;

hugbug added a commit that referenced this issue Aug 16, 2015

hugbug added a commit that referenced this issue Aug 16, 2015

#72: search in specified fields
- column name and a colon should be used as prefix;
- example: “status:downloading|status:processing”
- if no field is specified the search is performed through all fields.

hugbug added a commit that referenced this issue Aug 16, 2015

#72: search in hidden fields
- in addition to fields shown in tables all other fields coming from
API are now searchable;
- for list of available fields on downloads-tab see API-method
“listgroups”;
- for history-tab see API-method “history”;
- for messages-tab see API-method “log”;
- field names must be typed with correct letter-case;
- visible fields (shown in tables) must be typed in lower case.

hugbug added a commit that referenced this issue Aug 16, 2015

#72: search field names using any letter case
- field names can be typed in any letter case, for example “parstatus”
instead of “ParStatus”;
- there is a potential ambiguity when searching through field “status”:
this field exists in both as column in table and as field in the API;
although it has the same meaning the content is slightly different, the
field in API is more technical and includes extra text, the field in
column is more user friendly;
- to avoid ambiguity use the correct letter case (“Status”) to search
in API field, use low letter case (“status”) to search in table; any
other letter case form (like “sTatus” or “STATUS”) will search in table
too since it has precedence;

hugbug added a commit that referenced this issue Aug 17, 2015

#72: comparison operators for integer fields
- search box now supports operators : = <> > < >= <=
- new search fields in downloads list: sizemb, sizegb, leftmb, leftgb,
agem, ageh, aged - download size in MB, GB, left size in MB, GB, age in
minutes, hours, days;
- the same fields except leftmb, leftgb are also available in history.

hugbug added a commit that referenced this issue Aug 17, 2015

#72: advanced search in settings
- searchable fields: name, description, value.
@hugbug

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2015

Done.

@hugbug hugbug closed this Aug 18, 2015

hugbug added a commit to nzbget/nzbget.github.io that referenced this issue Aug 18, 2015

hugbug added a commit that referenced this issue Aug 18, 2015

#72: popup menu for filter input
- currently with only one menu item “quick help”;
- will be expanded in the future with recent searches.

hugbug added a commit that referenced this issue Aug 19, 2015

#72: saved filters in filter menu
- filters can be saved, deleted and renamed.
@hugbug

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2015

Bug reported on forum:

When using the search/filter box in an NZB files list the filter gets applied to the next NZB files list you click into as well. i.e. the filter does not get cleared/reset when you close out of the files box or go back into it.

How to reproduce:

Click an NZB in the queue.
Go to the files dialog box
Type something in the search to filter the files list
Click cancel or save to close the dialog

Click the same or another NZB in the queue
Go to the files dialog box
The Search box (DownloadsEdit_FileTable_filter) is blank, yet the same filter is still applied
Press space and backspace to clear the filter and all the files show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.