New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #29 #278

Merged
merged 13 commits into from Sep 16, 2016

Conversation

Projects
None yet
2 participants
@guaguasi
Contributor

guaguasi commented Sep 10, 2016

Took a little longer than I planned. Refactored twice. Hopefully worth it lol.

Adds more robust pause control as requested in issue #29

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 10, 2016

Member

Great job you did!

I have one suggestion - the table with examples is useful but scares a bit (too much info). I would prefer a one sentence help (something like For example "30m", "2h" or "=18:00") and button "Quick help" which shows the full help screen in a separate dialog, like in the "Add files dialog".

Member

hugbug commented Sep 10, 2016

Great job you did!

I have one suggestion - the table with examples is useful but scares a bit (too much info). I would prefer a one sentence help (something like For example "30m", "2h" or "=18:00") and button "Quick help" which shows the full help screen in a separate dialog, like in the "Add files dialog".

@guaguasi

This comment has been minimized.

Show comment
Hide comment
@guaguasi

guaguasi Sep 14, 2016

Contributor

The examples are really the only formats accepted. I'll do as you say and add the table in a "Quick help" style section and that sentence where the table is currently.

I'll get to it when I have some time, most likely this weekend. If I can manage, I'll do it tonight or tomorrow night.

Contributor

guaguasi commented Sep 14, 2016

The examples are really the only formats accepted. I'll do as you say and add the table in a "Quick help" style section and that sentence where the table is currently.

I'll get to it when I have some time, most likely this weekend. If I can manage, I'll do it tonight or tomorrow night.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 14, 2016

Member

A small thing: when the preview text appears or hides the dialog height changes. It'd be better to keep the height constant. May be some explanaition text in the preview box or just keep it empty but still visible to prevent height changes.

I've also noticed that opening the dialog for second time shows a preview text from previous usage.

Member

hugbug commented Sep 14, 2016

A small thing: when the preview text appears or hides the dialog height changes. It'd be better to keep the height constant. May be some explanaition text in the preview box or just keep it empty but still visible to prevent height changes.

I've also noticed that opening the dialog for second time shows a preview text from previous usage.

@guaguasi

This comment has been minimized.

Show comment
Hide comment
@guaguasi

guaguasi Sep 14, 2016

Contributor

Ended up just doing it. Let me know if there are anything else.

Contributor

guaguasi commented Sep 14, 2016

Ended up just doing it. Let me know if there are anything else.

@hugbug hugbug merged commit e269d8f into nzbget:develop Sep 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

hugbug added a commit that referenced this pull request Oct 8, 2016

hugbug added a commit that referenced this pull request Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment