New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #276 #280

Merged
merged 3 commits into from Sep 19, 2016

Conversation

Projects
None yet
2 participants
@guaguasi
Contributor

guaguasi commented Sep 15, 2016

Simple css tweak for #276

@guaguasi guaguasi changed the title from fix for issue #276 to Fix for issue #276 Sep 15, 2016

@guaguasi guaguasi changed the title from Fix for issue #276 to Fix for Issue #276 Sep 15, 2016

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 16, 2016

Member

At least on my monitor #FFFFF5 is hard to differentiate from white especially if only one row is selected. The following values work fine for me:

tr.checked:nth-child(odd) .progress {
background-color: #FFFFE8;
}

.table-striped tbody tr.checked:nth-child(odd) td,
.checked .progress {
background-color: #FFFFD8;

If you agree please update the PR and I'll merge it. Thank you.

Member

hugbug commented Sep 16, 2016

At least on my monitor #FFFFF5 is hard to differentiate from white especially if only one row is selected. The following values work fine for me:

tr.checked:nth-child(odd) .progress {
background-color: #FFFFE8;
}

.table-striped tbody tr.checked:nth-child(odd) td,
.checked .progress {
background-color: #FFFFD8;

If you agree please update the PR and I'll merge it. Thank you.

@guaguasi

This comment has been minimized.

Show comment
Hide comment
@guaguasi

guaguasi Sep 16, 2016

Contributor

Looks good to me, except I also darkened the hover color slightly:

.table tbody tr.checked:hover, .table tbody tr.checked:hover td { background-color: #FFFFC0; }

Thoughts?

Contributor

guaguasi commented Sep 16, 2016

Looks good to me, except I also darkened the hover color slightly:

.table tbody tr.checked:hover, .table tbody tr.checked:hover td { background-color: #FFFFC0; }

Thoughts?

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 16, 2016

Member

Looks good.

Member

hugbug commented Sep 16, 2016

Looks good.

@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Sep 17, 2016

Member

Will you make a commit with the changes?

Member

hugbug commented Sep 17, 2016

Will you make a commit with the changes?

@guaguasi

This comment has been minimized.

Show comment
Hide comment
@guaguasi

guaguasi Sep 18, 2016

Contributor

Had a busy weekend. We're good now.

Contributor

guaguasi commented Sep 18, 2016

Had a busy weekend. We're good now.

@hugbug hugbug merged commit 8438878 into nzbget:develop Sep 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment