Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct LAN/WLAN ip address after installing #42

Merged
merged 1 commit into from Jun 29, 2015

Conversation

Projects
None yet
2 participants
@sanderjo
Copy link
Contributor

commented Jun 29, 2015

@hugbug

This comment has been minimized.

Copy link
Member

commented Jun 29, 2015

Thank you.

The tricky part about installer is that it should work on many systems. It was tested on many busybox variants. With busybox you never know what commands are available and how much they were stripped.

Since we can't expect such advanced commands like "ifconfig" to work we must wrap the calls with safety straps like { .. } > /dev/null 2>&1 - suppress error reporting, for example if "ifconfig" isn't available.

To test your code for durability replace "route" with "route1" and "ifconfig" with "ifconfig1" to pretend the commands are not available.

Don't worry, I'll add the safety wrapper myself. Thanks again for the improvement.

hugbug added a commit that referenced this pull request Jun 29, 2015

Merge pull request #42 from sanderjo/show-ip-address
Improved detection of local IP-address in Linux installer

@hugbug hugbug merged commit 37252fa into nzbget:develop Jun 29, 2015

hugbug added a commit that referenced this pull request Jun 29, 2015

@hugbug

This comment has been minimized.

Copy link
Member

commented Jun 29, 2015

  • removed the info message for local address. The info about web-interface were supposed to be a one-liner, not three lines. It's primary for users who install on remote machines. Local address 127.0.0.1 works always anyway.
  • good idea about printing default login name and password 👍
  • added safety wrapper {..}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.