New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on sizes of externally generated files #437

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@sinic
Contributor

sinic commented Aug 31, 2017

My abc.00 is smaller than 4704 bytes, breaking rename/rename_opt2_test.py::test_rename_obf3dmf2 due to a failed str.replace.

Matching arbitrary sizes (with re.sub) prevents problems like this.

Don't rely on sizes of externally generated files
Tests that try to match exact file sizes are prone to break for
unexpected versions of p7zip and par2cmdline.
@hugbug

This comment has been minimized.

Show comment
Hide comment
@hugbug

hugbug Aug 31, 2017

Member

You are right of course. Thanks.

Member

hugbug commented Aug 31, 2017

You are right of course. Thanks.

@hugbug hugbug merged commit 49a0292 into nzbget:develop Aug 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

hugbug added a commit that referenced this pull request Oct 9, 2017

#437: don't rely on sizes of externally generated files
Tests that try to match exact file sizes are prone to break for unexpected versions of p7zip and par2cmdline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment