Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated scripts to accept special characters in password #453

Merged
merged 4 commits into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@BernCarney
Copy link
Contributor

commented Sep 28, 2017

Fix for #453

@hugbug

This comment has been minimized.

Copy link
Member

commented Sep 28, 2017

Great. Thank you!

Can you please change it to quote the string when building rpcurl, not when assigning to variable password as that would be more logical. Also usernamemust be quoted as well.

@BernCarney

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2017

@BernCarney BernCarney closed this Sep 28, 2017

@BernCarney BernCarney reopened this Sep 28, 2017

@BernCarney
Copy link
Contributor Author

left a comment

Updated PR

@hugbug

This comment has been minimized.

Copy link
Member

commented Sep 29, 2017

Thanks for your contribution!

This dictionary feels like overkill 😄 Why not just use quotewhen building rpcUrl?

rpcUrl = 'http://%s:%s@%s:%s/xmlrpc' % (quote(username), quote(password), host, port);
@BernCarney

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2017

@hugbug

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

Would you like to commit a change for that or should I do it myself?

@BernCarney

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

@hugbug all set

@hugbug hugbug merged commit 24a4542 into nzbget:develop Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hugbug

This comment has been minimized.

Copy link
Member

commented Oct 5, 2017

Thank you!
Merged.

hugbug added a commit that referenced this pull request Oct 9, 2017

#452, #453: proper URL encoding in example pp-scripts
Updated scripts to accept special characters in nzbget password and username.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.