Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix compile warnings #590
Thanks for your contribution. A description would be helpful.
From all the changes I think I'm going to accept these two:
For other changes:
Hi @hugbug , for the reason of each of the fixes you can check the man page of gcc for example for a detailed explanation.
For these other changes:
The whole purpose of these fixes is to be able to compile with
You are right. That's a bug. Good thing to have this warning enabled then.
That code is 10 years old, I don't remember what it was back then. Right now Clang produces warning when compiling in analyse mode. Not a big issue probably if the purpose is -Wall. I can accept the change.
Can you change the code somehow to not use
You convinced me, I'm going to accept the whole PR. Although I don't like some changes they are probably for good.