Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vala binding can't change map source #50

Closed
supercamel opened this issue Apr 18, 2016 · 0 comments
Closed

Vala binding can't change map source #50

supercamel opened this issue Apr 18, 2016 · 0 comments
Milestone

Comments

@supercamel
Copy link
Contributor

@supercamel supercamel commented Apr 18, 2016

Hi,

When using Vala bindings, I cannot change the map source. Further investigation shows that the osm_gps_map_set() function is never called (line 1977 of osm-gps-map-widget.c). This is because the old map source is -1 (less than OSM_GPS_MAP_SOURCE_NULL).

Changing lines 1642 and 2837 from -1 to 0 seems to fix the problem. I can't see any real reason why is the map source should be initialised to -1.

Cheers!

@supercamel supercamel closed this Jul 9, 2016
@johnny-bit johnny-bit added this to the 1.2.0 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants