Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to insert image definitions into sitemap. #17

Open
wants to merge 1 commit into
base: master
from

Conversation

@johncave
Copy link

johncave commented May 19, 2016

I added the ability to add image definitions to the sitemap. Basically this works by optionally appending an array to the end of the addItem method call with the structure of the image tag you want to create. Can document this and send another pull request but wanted to know if you'd be interested in merging this code first.

@mablae

This comment has been minimized.

Copy link

mablae commented on d6cb097 May 15, 2016

Hello @johncave,

I need exactly the same functionality :)
could you please send a pull request upstream?

We could better work together instead of implementing it twice, what do you think?

@johncave

This comment has been minimized.

Copy link
Author

johncave commented May 19, 2016

@mablae Submitted a pull request but there's a couple of others that add the same functionality already sitting in its pull request queue. Also I haven't documented how to use the new functionality yet. Might get some time to write that this weekend and submit another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.